-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bouncing[IOS]/overScroll Edge[Android] effect to the lists of the app #5136
Conversation
@shawnborton I have updated the list of components in the description which are enabled for the effect. However, there are other components that I would like to confirm first.
Please let me know if there are any other lists that you want me to activate. |
I think that sounds pretty good to me, I think basically any view that can scroll would have this behavior. |
All set here. Ready for review @shawnborton @chiragsalian. Thanks for the patience. |
I didn't get a chance to review today but i'll review it tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me. One question though, is there a reason bounce isn't added here. I briefly tested the terms page and the scroll did bounce even though the scrollView didn't have bounce mentioned so just wanted to confirm we're not missing something.
Oh, Thanks @chiragsalian for end moment catch. I didn't notice |
Also, the terms page is the only one i noticed that has a scroll in the middle of the text which is pretty weird. Was wondering if you can resolve that here, To test the terms page I followed the steps from this PR. |
@chiragsalian Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you for the changes. Looks good to me and works well.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @chiragsalian in version: 1.0.98-2 🚀
|
Details
#4816 (comment)
Enabled pages:
Fixed Issues
$ #4816
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
effect-opt-i.mp4
Android
output_file.mp4