Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation for age in Bank Requestor Form #5149

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

akshayasalvi
Copy link
Contributor

@pecanoro Can you please review this PR?

Details

  • Added age validation to the date field of Bank Account Requestor

Fixed Issues

$ #5030

Tests

  1. Tested by entering date > 18 years
  2. Tested by entering date < 18 years

QA Steps

  1. Go to bank-account/requestor step
  2. Fill in date that is lesser than 18 years
  3. It should show a validation message of age for the given date.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-date-valid

web-date-error

Mobile Web

mweb-date-valid

mweb-date-error

Desktop

desktop-date-valid

desktop-date-error

iOS

ios-date-valid

ios-date-error

Android

android-date-valid

android-date-error

@akshayasalvi akshayasalvi requested a review from a team as a code owner September 8, 2021 23:48
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team September 8, 2021 23:48
@pecanoro pecanoro merged commit ddd7f92 into Expensify:main Sep 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@@ -68,6 +68,15 @@ function isValidSSNLastFour(ssnLast4) {
return CONST.REGEX.SSN_LAST_FOUR.test(ssnLast4);
}

/**
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nab, unnecessary new line here

@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2021

🚀 Deployed to staging by @pecanoro in version: 1.0.95-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 10, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-17. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.96-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants