[Create Expense A/B] Tweak Onboarding Copy for Combined Track/Submit #51600

fabioh8010 · 2024-10-28T18:48:07Z

Details

This PR implements #51223.

Fixed Issues

#$ #51223
PROPOSAL:

Tests

Track Expense (Normal User)

Create an account that doesn't have the combinedTrackSubmit beta.
Select "Track and budget expenses" option in the Onboarding flow and finish the process.
In Concierge chat, click in the "Track an expense" task and assert its using the non-beta description (mentioning "Track expense").

Submit Expense (Normal User)

Create an account that doesn't have the combinedTrackSubmit beta.
Select "Get paid back by my employer" option in the Onboarding flow and finish the process.
In Concierge chat, click in the "Submit an expense" task and assert its using the non-beta description (mentioning "Submit expense").

Track Expense (Beta User)

Create an account that does have the combinedTrackSubmit beta enabled.
Select "Track and budget expenses" option in the Onboarding flow and finish the process.
In Concierge chat, click in the "Track an expense" task and assert its using the beta description (mentioning "Create expense") here.

Submit Expense (Beta User)

Create an account that does have the combinedTrackSubmit beta enabled.
Select "Get paid back by my employer" option in the Onboarding flow and finish the process.
In Concierge chat, click in the "Submit an expense" task and assert its using the beta description (mentioning "Create expense") here.

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-29.at.17.10.12-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-10-29.at.17.17.39-compressed.mov

iOS: Native

Screen.Recording.2024-10-29.at.17.36.42-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-10-29.at.17.40.27-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-29.at.17.43.40-compressed.mov

Screen.Recording.2024-10-29.at.17.47.34-compressed.mov

MacOS: Desktop

Screen.Recording.2024-10-29.at.17.51.51-compressed.mov

grgia · 2024-10-29T10:42:48Z

triggered a test build

grgia · 2024-10-29T16:16:03Z

grgia · 2024-10-29T16:17:35Z

Screen.Recording.2024-10-29.at.4.17.17.PM.mov

grgia · 2024-10-29T16:18:46Z

Screen.Recording.2024-10-29.at.4.18.24.PM.mov

grgia · 2024-10-29T16:23:09Z

Non beta:

grgia

LGTM and tests well!

melvin-bot · 2024-10-29T18:06:15Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia · 2024-10-30T12:28:48Z

@Ollyws could you prioritize this one?

Ollyws · 2024-10-30T12:29:47Z

@grgia Sure, reviewing now.

Ollyws · 2024-10-30T14:51:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Ollyws

LGTM.

grgia

@fabioh8010 could you merge main so I can approve, great work!

OSBotify · 2024-11-01T17:33:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-04T14:39:01Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

kavimuru · 2024-11-05T01:42:43Z

@fabioh8010 For the "Track Expense (Beta User)" which domain should we use? Applause.expensifail.com domain will not trigger onboarding flow

fabioh8010 · 2024-11-05T08:50:29Z

@fabioh8010 For the "Track Expense (Beta User)" which domain should we use? Applause.expensifail.com domain will not trigger onboarding flow

Can you help me here @grgia ?

mvtglobally · 2024-11-05T12:47:32Z

Here is additional info on the above request. We are unable to verify this PR right now,
Can this be tested internally?

trim.7F579828-CABB-48C3-A28A-2142FA5543CC.MOV

Julesssss · 2024-11-05T14:56:44Z

@fabioh8010 For the "Track Expense (Beta User)" which domain should we use? Applause.expensifail.com domain will not trigger onboarding flow

Hey @kavimuru. Can you provide some user accounts that we can add to the Beta manually.

kavimuru · 2024-11-05T16:21:24Z

@Julesssss
pomuntat+1beta1105@gmail.com
pomuntat+2beta1105@gmail.com

Julesssss · 2024-11-05T16:34:27Z

Thanks @kavimuru, I added the users to the beta.

grgia · 2024-11-05T16:34:42Z

BETA + track

Beta + submit

NO Beta - track

non beta + submit

grgia · 2024-11-05T16:34:51Z

Passes QA @Julesssss

Julesssss · 2024-11-05T16:38:12Z

TYSM, checking off

github-actions · 2024-11-06T00:02:34Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.57-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

Tweak Onboarding Copy for Combined Track/Submit

e61e17e

fabioh8010 mentioned this pull request Oct 28, 2024

[HOLD for payment 2024-11-13] [Create Expense A/B] Tweak Onboarding Copy for Combined Track/Submit #51223

Closed

grgia added the Ready To Build label Oct 29, 2024

Merge remote-tracking branch 'origin/main' into feature/51223

e2bbe7e

This comment has been minimized.

Sign in to view

grgia self-requested a review October 29, 2024 16:12

Expensify deleted a comment from github-actions bot Oct 29, 2024

grgia previously approved these changes Oct 29, 2024

View reviewed changes

fabioh8010 marked this pull request as ready for review October 29, 2024 18:06

fabioh8010 requested a review from a team as a code owner October 29, 2024 18:06

melvin-bot bot requested review from Ollyws and removed request for a team October 29, 2024 18:06

fabioh8010 changed the title ~~[WIP] [Create Expense A/B] Tweak Onboarding Copy for Combined Track/Submit~~ [Create Expense A/B] Tweak Onboarding Copy for Combined Track/Submit Oct 29, 2024

Ollyws approved these changes Oct 30, 2024

View reviewed changes

melvin-bot bot requested a review from grgia October 30, 2024 14:51

grgia reviewed Nov 1, 2024

View reviewed changes

Merge branch 'main' into feature/51223

ee164a4

fabioh8010 dismissed grgia’s stale review via ee164a4 November 1, 2024 15:14

grgia approved these changes Nov 1, 2024

View reviewed changes

grgia merged commit 069780c into Expensify:main Nov 1, 2024
17 checks passed

github-actions bot mentioned this pull request Nov 4, 2024

Deploy Checklist: New Expensify 2024-11-04 #51953

Closed

63 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Create Expense A/B] Tweak Onboarding Copy for Combined Track/Submit #51600

[Create Expense A/B] Tweak Onboarding Copy for Combined Track/Submit #51600

fabioh8010 commented Oct 28, 2024 •

edited

Loading

grgia commented Oct 29, 2024

This comment has been minimized.

grgia commented Oct 29, 2024

grgia commented Oct 29, 2024

grgia commented Oct 29, 2024

grgia commented Oct 29, 2024

grgia left a comment

melvin-bot bot commented Oct 29, 2024

grgia commented Oct 30, 2024

Ollyws commented Oct 30, 2024

Ollyws commented Oct 30, 2024

Ollyws left a comment

grgia left a comment

OSBotify commented Nov 1, 2024

github-actions bot commented Nov 4, 2024

kavimuru commented Nov 5, 2024

fabioh8010 commented Nov 5, 2024

mvtglobally commented Nov 5, 2024

Julesssss commented Nov 5, 2024

kavimuru commented Nov 5, 2024

Julesssss commented Nov 5, 2024

grgia commented Nov 5, 2024

grgia commented Nov 5, 2024

Julesssss commented Nov 5, 2024

github-actions bot commented Nov 6, 2024

[Create Expense A/B] Tweak Onboarding Copy for Combined Track/Submit #51600

[Create Expense A/B] Tweak Onboarding Copy for Combined Track/Submit #51600

Conversation

fabioh8010 commented Oct 28, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

grgia commented Oct 29, 2024

This comment has been minimized.

grgia commented Oct 29, 2024

grgia commented Oct 29, 2024

grgia commented Oct 29, 2024

grgia commented Oct 29, 2024

grgia left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 29, 2024

grgia commented Oct 30, 2024

Ollyws commented Oct 30, 2024

Ollyws commented Oct 30, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 1, 2024

github-actions bot commented Nov 4, 2024

kavimuru commented Nov 5, 2024

fabioh8010 commented Nov 5, 2024

mvtglobally commented Nov 5, 2024

Julesssss commented Nov 5, 2024

kavimuru commented Nov 5, 2024

Julesssss commented Nov 5, 2024

grgia commented Nov 5, 2024

grgia commented Nov 5, 2024

Julesssss commented Nov 5, 2024

github-actions bot commented Nov 6, 2024

fabioh8010 commented Oct 28, 2024 •

edited

Loading