-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Personal and Corp Karma images to help article #51842
Conversation
A preview of your ExpensifyHelp changes have been deployed to https://622f8308.helpdot.pages.dev ⚡️ |
Making some small revisions
Small revisions to a few sentences to make them more clear.
Sorry just one more edit to bold some of the words
Awesome these changes look good @blimpich - I think this is good for a review. Would it be possible to also update these in-app links to the new help article, too? Happy to open a new GH if that's better to make those changes! Corp Karma at Settings > Workspaces > group > Subscription settings Personal Karma at Settings > Individual Thank you! |
@Christinadobrzyn yes please! Could you make an issue, mark it as daily, and assign it to me with a description of what links should be updated? I probably won't get to it till early next week but an issue will help me remember |
Actually I'll just quickly make the PR, should only take a couple minutes. |
Made and issue and PR for fixing the old helpdot links and pointing them towards the new one 👍 |
🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.57-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.57-10 🚀
|
Explanation of Change
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.