fix image from opening in both a new tab and app modal #52013

huult · 2024-11-05T06:03:03Z

Details

Fixed Issues

$ #50260
PROPOSAL: #50260 (comment)

Tests

Copy the content from step 3 to step 4 in this issue [HOLD for payment 2024-10-24] [$250] Search - Attachment from qa.guide loads infinitely when opened in Search #50006.
Open the Expensify app.
Navigate to any chat.
Paste the copied content into the chat.
Click on the image in the chat.
Verify that only the attachment modal opens and check that the image href link is displayed under the "Attachment" title in the modal.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Copy the content from step 3 to step 4 in this issue [HOLD for payment 2024-10-24] [$250] Search - Attachment from qa.guide loads infinitely when opened in Search #50006.
Open the Expensify app.
Navigate to any chat.
Paste the copied content into the chat.
Click on the image in the chat.
Verify that only the attachment modal opens and check that the image href link is displayed under the "Attachment" title in the modal.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-05.at.12.46.07.mp4

Android: mWeb Chrome

Screen.Recording.2024-11-05.at.12.48.00.mp4

iOS: Native

Screen.Recording.2024-11-05.at.12.40.23.mp4

iOS: mWeb Safari

Screen.Recording.2024-11-05.at.12.41.51.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-11-05.at.12.34.42.mp4

MacOS: Desktop

Screen.Recording.2024-11-05.at.12.36.38.mp4

melvin-bot · 2024-11-05T06:03:08Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx

src/components/AnchorForCommentsOnly/types.ts

src/components/Header.tsx

src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.tsx

src/pages/home/report/ReportAttachments.tsx

…n-modal-and-new-tab

suneox · 2024-11-06T04:12:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-15.at.11.08.29.mp4

Android: mWeb Chrome

Screen.Recording.2024-11-15.at.10.49.37.mp4

iOS: Native

Screen.Recording.2024-11-15.at.11.15.15.mp4

iOS: mWeb Safari

Screen.Recording.2024-11-15.at.09.40.49.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-11-15.at.09.37.02.mp4

MacOS: Desktop

Screen.Recording.2024-11-15.at.09.37.57.mp4

src/components/Header.tsx

src/components/AttachmentModal.tsx

src/components/Header.tsx

src/components/Attachments/AttachmentCarousel/extractAttachments.ts

suneox · 2024-11-07T02:53:57Z

Open any chat.

Send a markdown image using a URL that points to a non-existent image. For example: .

Verify that a "Gallery Not Found" image is displayed and that the option to open the modal is disabled.

@huult The QA Step doesn't match with this issue

huult · 2024-11-07T03:16:59Z

@suneox , I've updated QA step

suneox · 2024-11-07T05:55:44Z

@huult Could you please handle an issue the attachmentLink still show on image without link?

Screen.Recording.2024-11-07.at.12.49.50.mov

Step reproduce:

S1: Paste image with link: [!(https://picsum.photos/222)](https://picsum.photos)
S2: Paste image without link: !(https://picsum.photos/222)

huult · 2024-11-07T08:06:19Z

@suneox Your case tests the uniqueSources logic. With the attachment carousel, we display only the unique attachment source. In the tested case, we have the same source with different subtitle links, so we will still show two attachments with the same source but different subtitles, correct?

huult · 2024-11-08T09:43:23Z

@suneox I am working on the case where the attachment has the same source but different links. I need additional time to complete this, so the estimated time of completion is approximately 3 working days. Thank you.

suneox · 2024-11-08T11:18:37Z

@suneox I am working on the case where the attachment has the same source but different links. I need additional time to complete this, so the estimated time of completion is approximately 3 working days. Thank you.

ok Thank for your feedback

…n-modal-and-new-tab

huult · 2024-11-12T17:34:12Z

@suneox , I have finished updating the case for the unique source with the different link mentioned above. Could you please check again? I have tested many cases related to this change. If you detect any new bugs due to the change, please let me know. Thank you

…n-modal-and-new-tab

huult · 2024-11-14T08:08:26Z

@suneox What do you think of my changes?

suneox · 2024-11-14T09:01:12Z

@suneox What do you think of my changes?

I'll check your update today

suneox · 2024-11-15T03:12:56Z

@suneox , I have finished updating the case for the unique source with the different link mentioned above. Could you please check again? I have tested many cases related to this change. If you detect any new bugs due to the change, please let me know. Thank you

@huult Have you got this error when open attachment modal? In case, same source but attachment link is difference

huult · 2024-11-15T03:15:13Z

const extractItemKey = useCallback(
(item: Attachment) => (typeof item.source === 'string' || typeof item.source === 'number' ? source-${item.source}|${item.attachmentLink} : reportActionID-${item.reportActionID}),
[],

@suneox , I've updated the key for that. I will check it. Thank you!

…n-modal-and-new-tab

huult · 2024-11-15T03:30:30Z

@suneox I've updated it. Could you check again?

blimpich

Couple minor changes requested, after those are addressed we should be good to merge 👍

src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.tsx

src/components/AnchorForCommentsOnly/types.ts

…n-modal-and-new-tab

huult · 2024-11-16T05:59:38Z

@blimpich I have already updated your feedback. Could you please check it again? Thank you!

OSBotify · 2024-11-18T18:17:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-19T01:22:05Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.64-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2024-11-21T01:16:02Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.64-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

ishpaul777 · 2024-11-30T19:29:25Z

src/components/Attachments/AttachmentCarousel/index.tsx

@@ -70,7 +70,7 @@ function AttachmentCarousel({report, source, onNavigate, setDownloadButtonVisibi
        setShouldShowArrows(true);
    }, [canUseTouchScreen, page, setShouldShowArrows]);

-    const compareImage = useCallback((attachment: Attachment) => attachment.source === source, [source]);
+    const compareImage = useCallback((attachment: Attachment) => attachment.source === source && attachment.attachmentLink === attachmentLink, [attachmentLink, source]);


This caused a regression here #52013, We should only compare the attachmentLink if attachmentLink prop exists

fix image from opening in both a new tab and app modal

c744ec5

huult requested a review from a team as a code owner November 5, 2024 06:03

melvin-bot bot requested review from suneox and removed request for a team November 5, 2024 06:03