fix wallet phone validation page #52082

NJ-2020 · 2024-11-05T23:07:56Z

Explanation of Change

Fixed Issues

$ #51491
PROPOSAL: #51491 (comment)

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Pre-conditions:

Workspace is connected with a bank account
Workspace has a member invited
Workspace has enabled Expensify card

Issue a physical card for the member
Sign in as the member
Go to settings > wallet > assigned card > get physical card
Go through the flow until phone number input page
Input this: 8005555555 phone number and click enter
Make sure it redirects to the next step if the entered phone number belongs to the country you are operating from, otherwise, an "Invalid phone number" error is displayed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-03.at.17.01.26.mov

Android: mWeb Chrome

Screen.Recording.2024-12-04.at.07.49.07.mov

iOS: Native

Screen.Recording.2024-12-04.at.08.49.25.mov

iOS: mWeb Safari

Screen.Recording.2024-12-04.at.08.12.02.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-04.at.09.11.01.mov

MacOS: Desktop

Screen.Recording.2024-12-04.at.08.57.14.mov

MacOS: Desktop

Screen.Recording.2024-11-06.at.22.30.30.mov

melvin-bot · 2024-11-07T06:36:21Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane · 2024-11-14T12:32:20Z

@NJ-2020 How can I add a test Expensify card. Does it need to go through Concierge?

NJ-2020 · 2024-11-15T10:27:47Z

@sobitneupane You need to use staging server to make sure it will not go to production mode

User A, User B
A: Enable "Use staging server"
A: Go to any workspace/create new workspace
A: Enable Expensify card features
A: Connect with any bank
A: Invite user B
A: Inside Expensify card, issue new card for user B
B: Go to settings > wallet > assigned card > select any card
B: Go through the flow until phone number input page
B: Input this: 8005555555 phone number and click enter
B: Make sure it got redirected to the next step without any issue

sobitneupane · 2024-11-18T17:03:23Z

Thanks @NJ-2020.

Make sure it got redirected to the next step without any errors

I believe it's true only if user is in US. I believe, user not in US, will get error message.

Can you please add all test steps in QA as well.

sobitneupane

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-19.at.00.14.13.mov

iOS: Native

Screen.Recording.2024-11-18.at.23.48.42.mov

iOS: mWeb Safari

Screen.Recording.2024-11-18.at.22.43.23.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-18.at.22.32.05.mov

MacOS: Desktop

Screen.Recording.2024-11-18.at.23.53.59.mov

sobitneupane · 2024-11-18T18:32:32Z

@NJ-2020 EsLint check is failing.

NJ-2020 · 2024-11-19T05:17:03Z

EsLint check is failing.

@sobitneupane The eslint errors is not coming from my PR:

NJ-2020 · 2024-11-19T05:19:06Z

Can you please add all test steps in QA as well.

Done

sobitneupane · 2024-11-19T12:55:45Z

I believe it's true only if user is in US. I believe, user not in US, will get error message.

@NJ-2020 As you can see in the screen recordings here, QA test doesn't pass for me. I got Phone number not valid error. Is it expected? If yes, could you please update QA tests to address it?

The eslint errors is not coming from my PR:

Is it present in current main branch? Could you please merge main?

sobitneupane · 2024-12-02T12:03:30Z

Bump @NJ-2020 Could you please merge main and update the QA steps?

NJ-2020 · 2024-12-02T12:19:09Z

@sobitneupane Sorry for the delayed response, Okay will do that

I will be OOO for 1 day

NJ-2020 · 2024-12-04T03:01:24Z

@sobitneupane Done conflicts resolved

Regarding updating the QA steps, I am not sure here why I passed while inputing the number while I am from Indonesia as you can see here (from my IP)

But I don't know why, maybe because when creating the account(that I used for testing) I used US timezone

NJ-2020 · 2024-12-04T03:04:59Z

I just performed a new test on all platforms and it got working as expected

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-03.at.17.01.26.mov

Android: mWeb Chrome

Screen.Recording.2024-12-04.at.07.49.07.mov

iOS: Native

Screen.Recording.2024-12-04.at.08.49.25.mov

iOS: mWeb Safari

Screen.Recording.2024-12-04.at.08.12.02.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-04.at.09.11.01.mov

MacOS: Desktop

Screen.Recording.2024-12-04.at.08.57.14.mov

sobitneupane · 2024-12-05T08:31:26Z

Issue a physical card for the member

Sign in as the member

Go to settings > wallet > assigned card > get physical card

Go through the flow until phone number input page

Input this: 8005555555 phone number and click enter

Make sure it got redirected to the next step without any issues

Could you please update the sixth step:

Verify that:

It redirects to the next step if the entered phone number belongs to the country you are operating from.
Otherwise, an "Invalid phone number" error is displayed.

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

NJ-2020 · 2024-12-05T08:49:12Z

@sobitneupane Done

chiragsalian

PR LGTM, but you've got an ESLint error to address.

NJ-2020 · 2024-12-06T01:35:31Z

@chiragsalian The ESLint error is not coming from my PR

chiragsalian · 2024-12-06T19:06:38Z

Well it kinda is. So whenever we update ESLint with new rules, the person who modifies the related file should update the file to satisfy the rule. We sometimes allow to ignore and proceed if the PR is very large or time sensitive but then the next author working on the file would have the error and would need to tackle it. We can't keep ignoring it otherwise our files wont meet ESLint standards. In your case it's from the file GetPhysicalCardPhone.tsx which you modified.

Since this ESLint rule "withOnyx has been deprecated" has existed for a while, and the PR is neither time-sensitive nor very large you would have to tackle it. Sorry for the inconvenience, i don't think it should be too tricky but let us know if you have any questions.

chiragsalian · 2024-12-10T20:02:57Z

friendly bump, any update here @NJ-2020?

NJ-2020 · 2024-12-11T07:44:03Z

Hi, I am very sorry.
I am OOO now for few days.
i am currently mourning my father who has passed away yesterday.

Thanks

cc: @sobitneupane @chiragsalian

NJ-2020 · 2024-12-19T13:37:34Z

After pulling the latest changes from main, the eslint error is fixed elsewhere

cc: @chiragsalian

OSBotify · 2024-12-19T21:09:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-23T20:56:58Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	cancelled 🔪
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

github-actions · 2024-12-23T21:40:54Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-23T21:48:24Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T00:04:09Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T00:51:48Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T19:41:55Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T19:58:51Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-26T20:26:06Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

fix wallet phone validation page

a162fe7

NJ-2020 marked this pull request as ready for review November 7, 2024 06:36

NJ-2020 requested a review from a team as a code owner November 7, 2024 06:36

melvin-bot bot requested review from sobitneupane and removed request for a team November 7, 2024 06:36

fix eslint warning and unnecessary changes

8e3babe

sobitneupane reviewed Nov 18, 2024

View reviewed changes

Merge branch 'main' into fix/51491-wallet-page

d70db96

Merge branch 'Expensify:main' into fix/51491-wallet-page

2fdb8bd

sobitneupane reviewed Dec 5, 2024

View reviewed changes

sobitneupane approved these changes Dec 5, 2024

View reviewed changes

melvin-bot bot requested a review from chiragsalian December 5, 2024 08:38

chiragsalian reviewed Dec 5, 2024

View reviewed changes

Merge branch 'Expensify:main' into fix/51491-wallet-page

1a26f7d

Merge branch 'Expensify:main' into fix/51491-wallet-page

858e0e1

chiragsalian approved these changes Dec 19, 2024

View reviewed changes

chiragsalian merged commit 9e03b6a into Expensify:main Dec 19, 2024
16 checks passed

github-actions bot mentioned this pull request Dec 23, 2024

Deploy Checklist: New Expensify 2024-12-23 #54476

Closed

NJ-2020 mentioned this pull request Dec 24, 2024

[HOLD for payment 2025-01-07] [HOLD for payment 2025-01-02] Wallet - "phone number is not valid email address" error when activating card with phone number #54487

Closed

8 tasks

melvin-bot bot mentioned this pull request Dec 26, 2024

[$125] Web - Expensify Card - Inconsistent behavior of phone number validation for shipping details #51491

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix wallet phone validation page #52082

fix wallet phone validation page #52082

NJ-2020 commented Nov 5, 2024 •

edited

Loading

melvin-bot bot commented Nov 7, 2024

sobitneupane commented Nov 14, 2024

NJ-2020 commented Nov 15, 2024 •

edited

Loading

sobitneupane commented Nov 18, 2024

sobitneupane left a comment •

edited

Loading

sobitneupane commented Nov 18, 2024

NJ-2020 commented Nov 19, 2024

NJ-2020 commented Nov 19, 2024

sobitneupane commented Nov 19, 2024

sobitneupane commented Dec 2, 2024 •

edited

Loading

NJ-2020 commented Dec 2, 2024

NJ-2020 commented Dec 4, 2024

NJ-2020 commented Dec 4, 2024

sobitneupane commented Dec 5, 2024

sobitneupane left a comment

NJ-2020 commented Dec 5, 2024

chiragsalian left a comment

NJ-2020 commented Dec 6, 2024

chiragsalian commented Dec 6, 2024

chiragsalian commented Dec 10, 2024

NJ-2020 commented Dec 11, 2024

NJ-2020 commented Dec 19, 2024

OSBotify commented Dec 19, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 26, 2024

fix wallet phone validation page #52082

fix wallet phone validation page #52082

Conversation

NJ-2020 commented Nov 5, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 7, 2024

sobitneupane commented Nov 14, 2024

NJ-2020 commented Nov 15, 2024 • edited Loading

sobitneupane commented Nov 18, 2024

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane commented Nov 18, 2024

NJ-2020 commented Nov 19, 2024

NJ-2020 commented Nov 19, 2024

sobitneupane commented Nov 19, 2024

sobitneupane commented Dec 2, 2024 • edited Loading

NJ-2020 commented Dec 2, 2024

NJ-2020 commented Dec 4, 2024

NJ-2020 commented Dec 4, 2024

Screenshots/Videos

sobitneupane commented Dec 5, 2024

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

NJ-2020 commented Dec 5, 2024

chiragsalian left a comment

Choose a reason for hiding this comment

NJ-2020 commented Dec 6, 2024

chiragsalian commented Dec 6, 2024

chiragsalian commented Dec 10, 2024

NJ-2020 commented Dec 11, 2024

NJ-2020 commented Dec 19, 2024

OSBotify commented Dec 19, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 26, 2024

NJ-2020 commented Nov 5, 2024 •

edited

Loading

NJ-2020 commented Nov 15, 2024 •

edited

Loading

sobitneupane left a comment •

edited

Loading

sobitneupane commented Dec 2, 2024 •

edited

Loading