Skip showing create for new users if user already has a workspace #5244

Beamanator · 2021-09-14T13:31:10Z

cc @kevinksullivan @MitchExpensify @mateomorris

Details

In this comment we discovered that the global create menu still shows up if a user has a workspace, which is not what we want. This PR fixes that.

Fixed Issues

$ #5047 (part 2)

Tests

New test:

Run the app locally (on whatever device you're testing on)
Create a brand new account in expensify.com.dev
Go to https://www.expensify.com.dev/admin_policies, create a free plan
- You'll be redirected to http://localhost:8080/workspace//card
Verify the global create menu doesn't pop up

To make sure there's no regressions (from the original PR):

Ensure that menu opens for new users & existing users logging in for the first time since update

Sign in
Validate that menu opens
Refresh
Validate menu doesn't open

Ensure that menu doesn't open for existing users who the menu has already opened for

Sign in
Validate that menu doesn't open

QA Steps

New test:

Create a brand new account in expensify.com
Go to https://www.staging.expensify.com/admin_policies, create a free plan
- You'll be redirected to https://staging.new.expensify.com/workspace//card
Verify the global create menu doesn't pop up behind

To make sure there's no regressions (from the original PR):

Using a brand new account:

Sign in after signing up
Verify that the global create menu opens automatically

Using an existing account which hasn't seen the menu open automatically yet

Sign in
Verify that the global create menu opens automatically

Using the same existing account

Refresh the page
Verify that the global create menu doesn't open

Tested On

Web
Mobile Web (having trouble with this)
~~Desktop~~ (Can't test here since we don't have a desktop old expensify app that could open the desktop new expensify app)
~~iOS~~ (Can't create a workspace from old mobile expensify)
~~Android~~ (Can't create a workspace from old mobile expensify)

Screenshots

Web

Screen.Recording.2021-09-14.at.3.37.23.PM.mov

Mobile Web

Really difficult to get this... May only be possible in staging

Desktop

N/A

iOS

N/A

Android

N/A

robertjchen

LGTM, thanks!

OSBotify · 2021-09-15T17:07:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2021-09-15T21:15:53Z

🚀 Deployed to staging by @robertjchen in version: 1.0.98-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

isagoico · 2021-09-16T17:40:32Z

@Beamanator I was unable to test the New Test Section because of this issue https://github.com/Expensify/Expensify/issues/177739. The rest of the steps were a pass.

isagoico · 2021-09-17T15:30:49Z

@Beamanator Friendly bump here. https://github.com/Expensify/Expensify/issues/177739 is blocking a section of QA

francoisl · 2021-09-18T00:01:30Z

Testing this @kevinksullivan right now

francoisl · 2021-09-18T00:12:22Z

Hm yeah so it sounds like we can't fully test this until https://github.com/Expensify/Expensify/issues/177739 is resolved unfortunately, you can't create a workspace right now.

@Beamanator feel free to post an update if you can think of an alternative way to test

Beamanator · 2021-09-18T09:19:45Z

Sorry for being super slow responding! :O Not sure how I missed this

Beamanator · 2021-09-18T09:46:02Z

Since the new workspace creation happens once we are redirected to New Expensify, I was hoping we should be able to do:

Create brand new account in staging.expensify.com/inbox
Figure out your account ID via User.getAccountID()
Watch network requests for GetAccountValidateCode when creating a free plan from https://www.staging.expensify.com/admin_policies
- keep Validate Code for next step
Manually navigate to http://staging.new.expensify.com/v/<accountID>/<validateCode>/workspace/new-workspace
Verify the global create menu doesn't show up, since a workspace should have been created for the user

However, GetAccountValidateCode failed 🤷 @francoisl do you know of another way to get a validate code?

flodnv · 2021-09-20T14:44:30Z

GetAccountValidateCode failed

This is expected. See https://expensify.slack.com/archives/CC7NECV4L/p1631817495283000

jboniface · 2021-09-20T18:29:51Z

This PR is blocking deploy and can't be tested until https://github.com/Expensify/Expensify/issues/177739 is fixed. can we please revert this PR so that we can deploy without it?

cc @kevinksullivan

(dm'd robert)

bondydaa · 2021-09-20T19:01:30Z

src/pages/home/sidebar/SidebarScreen.js

+                // For some reason, the menu doesn't open without the timeout
+                setTimeout(() => {
+                    this.toggleCreateMenu();
+                }, 200);


🤮 we should figure out how to do this without a setTimeout these hacks end up biting us later down the road because anything else that depends on this code then will have to use a timeout/delay to push it's rendering to the end of the stack.

This setTimeout is currently our only solution for auto-opening the global create on load, I made this issue for people to look into solutions - read the discussions, it's not a straightforward solutions sadly :D

We even increased from 200 ms to 1500 ms here: #5369

I wouldn't say one comment from a contributor is an "exhaustive" discussion on how best to fix this 😅 but I do agree with Rory's comment so did we ever follow up with react-navigation on this?

LOL I meant this issue: #5303 :D (many more comments haha)

bondydaa · 2021-09-20T19:04:19Z

reverting this here #5360 to unblock the deploy

OSBotify · 2021-09-20T21:01:01Z

🚀 Deployed to production by @Jag96 in version: 1.0.99-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

MitchExpensify · 2021-09-21T16:31:45Z

a note on this - We are continuing to experience this issue and investigating why here cc @Beamanator

Alex is going to continue looking while online today and we'll need to find someone to keep the work going if not resolved by the time Alex clocks off for the night. Looking for volunteers for the baton pass now

MitchExpensify · 2021-09-21T17:34:29Z

Let's focus our investigation here #5392

Beamanator added 2 commits September 14, 2021 15:23

Don't show global create for new users if has workspace

c8608be

Fix some comment formatting

0aa2cf2

Beamanator requested a review from a team as a code owner September 14, 2021 13:31

Beamanator self-assigned this Sep 14, 2021

MelvinBot requested review from robertjchen and removed request for a team September 14, 2021 13:31

Beamanator changed the title ~~Skip showing create for new users if has workspace~~ Skip showing create for new users if user already has a workspace Sep 14, 2021

robertjchen approved these changes Sep 15, 2021

View reviewed changes

robertjchen merged commit 09e2d94 into main Sep 15, 2021

robertjchen deleted the beaman-skipShowingCreateForNewUsersIfHasWorkspace branch September 15, 2021 17:07

OSBotify mentioned this pull request Sep 15, 2021

Deploy Checklist: New Expensify 2021-09-15 #5279

Closed

27 tasks

bondydaa reviewed Sep 20, 2021

View reviewed changes

bondydaa mentioned this pull request Sep 20, 2021

Revert "Skip showing create for new users if user already has a workspace" #5360

Merged

MitchExpensify mentioned this pull request Sep 21, 2021

Global create opening in workspace configuration screen #5392

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip showing create for new users if user already has a workspace #5244

Skip showing create for new users if user already has a workspace #5244

Beamanator commented Sep 14, 2021 •

edited

Loading

robertjchen left a comment

OSBotify commented Sep 15, 2021

OSBotify commented Sep 15, 2021

isagoico commented Sep 16, 2021

isagoico commented Sep 17, 2021

francoisl commented Sep 18, 2021

francoisl commented Sep 18, 2021

Beamanator commented Sep 18, 2021

Beamanator commented Sep 18, 2021

flodnv commented Sep 20, 2021

jboniface commented Sep 20, 2021 •

edited

Loading

bondydaa Sep 20, 2021

Beamanator Sep 21, 2021

Beamanator Sep 21, 2021

bondydaa Sep 21, 2021

Beamanator Sep 21, 2021 •

edited

Loading

bondydaa commented Sep 20, 2021

OSBotify commented Sep 20, 2021

MitchExpensify commented Sep 21, 2021

MitchExpensify commented Sep 21, 2021

Skip showing create for new users if user already has a workspace #5244

Skip showing create for new users if user already has a workspace #5244

Conversation

Beamanator commented Sep 14, 2021 • edited Loading

Details

Fixed Issues

Tests

To make sure there's no regressions (from the original PR):

QA Steps

To make sure there's no regressions (from the original PR):

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

robertjchen left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 15, 2021

OSBotify commented Sep 15, 2021

isagoico commented Sep 16, 2021

isagoico commented Sep 17, 2021

francoisl commented Sep 18, 2021

francoisl commented Sep 18, 2021

Beamanator commented Sep 18, 2021

Beamanator commented Sep 18, 2021

flodnv commented Sep 20, 2021

jboniface commented Sep 20, 2021 • edited Loading

bondydaa Sep 20, 2021

Choose a reason for hiding this comment

Beamanator Sep 21, 2021

Choose a reason for hiding this comment

Beamanator Sep 21, 2021

Choose a reason for hiding this comment

bondydaa Sep 21, 2021

Choose a reason for hiding this comment

Beamanator Sep 21, 2021 • edited Loading

Choose a reason for hiding this comment

bondydaa commented Sep 20, 2021

OSBotify commented Sep 20, 2021

MitchExpensify commented Sep 21, 2021

MitchExpensify commented Sep 21, 2021

Beamanator commented Sep 14, 2021 •

edited

Loading

jboniface commented Sep 20, 2021 •

edited

Loading

Beamanator Sep 21, 2021 •

edited

Loading