Redirect NewDot staging links in the same tab just like production links #5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomatoToaster
changed the title
marcaaron
previously approved these changes
Sep 14, 2021
|
Looks good to me but there are conflicts. |
marcaaron
reviewed
Sep 14, 2021
src/CONST.js
Outdated
| @@ -132,6 +132,7 @@ const CONST = { | |||
| STAGING_SECURE_URL: 'https://staging-secure.expensify.com/', | |||
| NEWDOT: 'new.expensify.com', | |||
| NEW_EXPENSIFY_URL, | |||
| NEW_EXPENSIFY_URL_STAGING: 'https://staging.new.expensify.com', | |||
There was a problem hiding this comment.
NAB really small nitpick but we have STAGING_SECURE_URL and most of these URL constants ending in URL maybe we can make this STAGING_NEW_EXPENSIFY_URL for consistency?
|
Resolved those conflicts and chose the better name. |
marcaaron
approved these changes
Sep 14, 2021
HorusGoul
approved these changes
Sep 15, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
27 tasks
|
🚀 Deployed to staging by @HorusGoul in version: 1.0.98-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @luacmartins @marcaaron @ctkochan22
Details
Follow up from this discussion on slack: https://expensify.slack.com/archives/C03TQ48KC/p1631576910170000
Related to this issue and testing it on staging
$ https://github.com/Expensify/Expensify/issues/176437
Tests
Same as Web QA done locally.
QA Steps
Send this exact message to yourself or any other user:
testing https://staging.new.expensify.com/settingsand verify that clicking on the hyper link opens the settings page in the same tab without opening a new page.Tested On
Screenshots
Web