Improve Switch to Expensify Classic flow #52526

hungvu193 · 2024-11-14T08:26:39Z

Explanation of Change

Update the Switch to Expensify Classic survey to drive better feedback

Fixed Issues

$ #51703
PROPOSAL: N/A

Tests

Case 1: People that are redirected into NewDot

Go to expensify.com
Choose the “1-9” signUpQualifier
Sign-up for a new account
Verify you’re redirected to new.expensify.com
Click the Settings bottom tab
Click Switch to Expensify Classic
Verify you see the new “Would you like to speak to a product manager?” page.
Click “Book a call”
Verify a Calendly link opens in a new browser tab
Go back to the new.expensify.com tab
Verify the RHP modal has closed.
Click Switch to Expensify Classic
Click No thanks
Choose any of the three radio button options
Click Next
Don’t enter any text in the free form text box
Click Next
Verify there’s no error on the page
Click Switch to Expensify Classic
Verify you’re redirected to expensify.com

Case 2: People not redirected into NewDot

Go to expensify.com
Choose the “10+” signUpQualifier
Sign-up for a new account
Verify you land in expensify.com
Click the Support button in the LHN of OldDot
Click Concierge
Verify you’re redirected to new.expensify.com
Click the Settings bottom tab
Click Switch to Expensify Classic
Verify you see the “Quick tip” page only
Click “Take me to Expensify Classic”
Verify you’re redirected to expensify.com

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same with Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-14.at.16.21.51.mov

Screen.Recording.2024-11-14.at.16.22.44.mov

Android: mWeb Chrome

Screen.Recording.2024-11-14.at.16.04.22.mov

Screen.Recording.2024-11-14.at.16.05.03.mov

iOS: Native

Screen.Recording.2024-11-14.at.15.55.50.mov

Screen.Recording.2024-11-14.at.15.48.15.mov

iOS: mWeb Safari

Screen.Recording.2024-11-14.at.15.39.58.mov

Screen.Recording.2024-11-14.at.15.41.05.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-14.at.14.15.10.mov

Screen.Recording.2024-11-14.at.15.31.48.mov

MacOS: Desktop

Screen.Recording.2024-11-14.at.15.31.48.mov

Screen.Recording.2024-11-14.at.14.15.10.mov

melvin-bot · 2024-11-14T09:23:42Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-11-14T09:25:12Z

Case 1:

Screen.Recording.2024-11-14.at.15.31.48.mov

Case 2:

Screen.Recording.2024-11-14.at.14.15.10.mov

hungvu193 · 2024-11-14T09:29:36Z

src/languages/es.ts

+        quickTip: 'Consejo rápido...',
+        quickTipSubTitle: 'Puedes ir directamente a Expensify Classic visitando expensify.com. Márcalo como favorito para tener un acceso directo fácil.',
+        bookACall: 'Reservar una llamada',
+        noThanks: 'No, gracias',
+        bookACallTitle: '¿Desea hablar con un responsable de producto?',
+        benefits: {
+            [CONST.EXIT_SURVEY.BENEFIT.CHATTING_DIRECTLY]: 'Charla directa sobre gastos e informes',
+            [CONST.EXIT_SURVEY.BENEFIT.EVERYTHING_MOBILE]: 'Posibilidad de hacerlo todo desde el móvil',
+            [CONST.EXIT_SURVEY.BENEFIT.TRAVEL_EXPENSE]: 'Viajes y gastos a la velocidad del chat',
+        },
+        bookACallTextTop: 'Al cambiar a Expensify Classic, se perderá:',
+        bookACallTextBottom: 'Nos encantaría hablar con usted para entender por qué. Puede concertar una llamada con uno de nuestros jefes de producto para hablar de sus necesidades.',


Requested translations here:
https://expensify.slack.com/archives/C01GTK53T8Q/p1731572881369449

Asked @Gonals to take a look to keep this moving!

Translation for "Take me to Expensify Classic" === Llévame a Expensify Classic

shawnborton · 2024-11-14T09:53:53Z

cc @trjExpensify for eyes on the review too, but I think this looks pretty good from a design perspective.

trjExpensify · 2024-11-14T12:34:28Z

Buildin'...

trjExpensify · 2024-11-14T12:37:30Z

@hungvu193 can we make sure the button label on the quickTip page reads Take me to Expensify Classic?

We purposely had a slightly different label name for that, so we can set up tracking it separately in FullStory.

hungvu193 · 2024-11-14T12:39:22Z

@hungvu193 can we make sure the button label on the quickTip page reads Take me to Expensify Classic?

We purposely had a slightly different label name for that, so we can set up tracking it separately in FullStory.

Sure. I think I missed that case, will update it along with the new translations.

src/languages/es.ts

trjExpensify · 2024-11-14T12:45:56Z

Great, I made the suggestion on the one translation change.

@shubham1206agra is this a PR you'll be able to review today? If not, please do let me know so I can find a replacement. :)

trjExpensify · 2024-11-14T13:46:22Z

Alright, did some testing. Overall looking good!

tom+1to9switch@trj.chat - Signed-up on expensify.com, selected 1-9 to be redirected to NewDot and get tryNewDot.classicRedirect.dismissed===false set for the account. I was shown the survey flow, book a call looks good etc. Then I switched, such that classicRedirect.dismissed becomes true. That looks good as well! Only thing to fix there is the label name on the quickTip page, as discussed above.

2024-11-14_13-17-51.mp4

tom+10plusswitch@trj.chat - signed-up on expensify.com and selected the 10+ option this time, so I have no tryNewDot NVP set at all for this account. We show the quickTrip page. That looks good!

2024-11-14_13-24-26.mp4

tom+dksksk@trj.chat - I signed-up on NewDot directly with this account. The tryNewDot NVP is added to the account, but classicRedirect.dismissed is empty (not set to false or true). That put me in a weird place where I saw the last page of the survey flow only for some reason.

2024-11-14_13-06-31.mp4

So two things on that bug:

We should show the quickTip page if tryNewDot NVP exists with classicRedirect.dismissed empty. Let’s account for that here in this PR with our logic, in case it ever happens.
I think we should be setting people who sign-up directly on NewDot to tryNewDot.classicRedirect.dismissed===false. That’s probably out of scope of this PR, but flagging it here as I spotted it. CC: @Julesssss for a second opinion on that.

shubham1206agra · 2024-11-14T14:15:35Z

@hungvu193 Please fix the tests.

hungvu193 · 2024-11-14T14:21:25Z

thrown: "Exceeded timeout of 30000 ms for a test. I don't think it's related to this PR.

hungvu193 · 2024-11-14T14:23:25Z

@trjExpensify Can you try to check the Onyx key nvp_tryNewDot in the bug that you posted? I'm unable to reproduce that bug so that will be helpful

trjExpensify · 2024-11-14T14:44:42Z

@trjExpensify Can you try to check the Onyx key nvp_tryNewDot in the bug that you posted? I'm unable to reproduce that bug so that will be helpful

Yeah, dismissed is empty:

trjExpensify · 2024-11-14T14:48:02Z

I've figured it out.

If you sign-up with a public domain on NewDot, we set tryNewDot.classicRedirect.dismissed===false.
If you sign-up with a private domain on NewDot, we set tryNewDot NVP but classicRedirect.dismissed is empty.

github-actions · 2024-11-14T15:35:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/52526/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/52526/NewExpensify.dmg	https://52526.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

trjExpensify · 2024-11-14T15:40:05Z

It's good!

mountiny

Code looks good ot me, just waiting for the checklist

shubham1206agra · 2024-11-14T17:28:31Z

Getting infinite load in NewDot prod on new account creation.

Edit - Took too much time to load.

shubham1206agra · 2024-11-14T17:42:43Z

Screen.Recording.2024-11-14.at.11.11.47.PM.mov

BUG: Page switches in background when clicked no thanks

shubham1206agra · 2024-11-14T17:44:33Z

Screen.Recording.2024-11-14.at.11.13.28.PM.mov

BUG: Navigation gets broken after clicking no thanks.

shubham1206agra · 2024-11-14T17:45:51Z

Screen.Recording.2024-11-14.at.11.15.09.PM.mov

BUG: Modal gets closed on clicking Book a call option.

trjExpensify · 2024-11-14T18:01:03Z

Screen.Recording.2024-11-14.at.11.15.09.PM.mov

BUG: Modal gets closed on clicking Book a call option.

This one is expected. We talked about it with design in the thread linked in the issue OP.

hungvu193 · 2024-11-15T02:53:30Z

Screen.Recording.2024-11-14.at.11.11.47.PM.mov
BUG: Page switches in background when clicked no thanks

This one also happens on staging

Screen.Recording.2024-11-15.at.09.52.17.mov

hungvu193 · 2024-11-15T02:54:00Z

Getting infinite load in NewDot prod on new account creation.

I don't think this is related to this PR 😄

hungvu193 · 2024-11-15T03:48:36Z

Fixed the navigation issue. Please test again @shubham1206agra

Screen.Recording.2024-11-15.at.10.22.33.mov

trjExpensify · 2024-11-15T11:10:13Z

Alrighty, how we looking here?

shubham1206agra · 2024-11-15T16:39:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-15.at.9.50.59.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-11-15.at.8.32.33.PM.mov

iOS: Native

Screen.Recording.2024-11-15.at.9.05.30.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-15.at.8.00.17.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-14.at.11.08.36.PM.mov

MacOS: Desktop

Screen.Recording.2024-11-15.at.8.45.17.PM.mov

mountiny

Thanks for the changes and testing

mountiny · 2024-11-18T13:38:54Z

@hungvu193 can you think of ways to add unit tests for these changes? Lets try to add it in a follow up. thanks!

OSBotify · 2024-11-18T13:50:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-19T01:22:47Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.64-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

hungvu193 · 2024-11-19T02:02:22Z

@hungvu193 can you think of ways to add unit tests for these changes? Lets try to add it in a follow up. thanks!

Sure. Lemme think about it.

mvtglobally · 2024-11-20T18:00:32Z

@mountiny This PR is not fully testable easily on Hybrid app.
Anyway you can help us highlight what exactly can be verified on Hybrid since we dont see URLs to be definitive

github-actions · 2024-11-21T01:16:44Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.64-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Improve switch to Expensify Classic flow

3d9c90a

hungvu193 mentioned this pull request Nov 14, 2024

[HOLD for payment 2024-11-28] Update the Switch to Expensify Classic survey to drive better feedback #51703

Open

hungvu193 marked this pull request as ready for review November 14, 2024 09:23

hungvu193 requested review from a team as code owners November 14, 2024 09:23

melvin-bot bot requested review from shubham1206agra and removed request for a team November 14, 2024 09:23

hungvu193 commented Nov 14, 2024

View reviewed changes

hungvu193 added 2 commits November 14, 2024 16:31

correct the page name

a6aab88

fix lint

34dffc7

trjExpensify assigned hungvu193 Nov 14, 2024

trjExpensify added the Ready To Build label Nov 14, 2024

trjExpensify reviewed Nov 14, 2024

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

hungvu193 added 2 commits November 14, 2024 20:49

update translations

7aec3e3

add stricter rule for quicktips

99ec928

improve shouldShowQuickTips condition

7cc635b

mountiny self-requested a review November 14, 2024 15:44

mountiny reviewed Nov 14, 2024

View reviewed changes

hungvu193 added 3 commits November 15, 2024 10:14

fix navigation issue

1fb2989

revert: shouldOpenBookACall

d0fad16

Onyx migration: ExitSurveyReasonPage

e748e6c

shubham1206agra approved these changes Nov 15, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny November 15, 2024 16:39

mountiny approved these changes Nov 18, 2024

View reviewed changes

mountiny merged commit 7c90011 into Expensify:main Nov 18, 2024
17 checks passed

github-actions bot mentioned this pull request Nov 19, 2024

Deploy Checklist: New Expensify 2024-11-19 #52733

Closed

54 tasks

IuliiaHerets mentioned this pull request Nov 19, 2024

Classic Flow - Redirection to app instead of classic web #52756

Closed

8 tasks

mkzie2 mentioned this pull request Nov 22, 2024

[$250] mWeb - Expensify Classic - Survey page is not shown while switching to expensify classic #52887

Open

8 tasks

Improve Switch to Expensify Classic flow #52526

Improve Switch to Expensify Classic flow #52526

Conversation

hungvu193 commented Nov 14, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 14, 2024

hungvu193 commented Nov 14, 2024

hungvu193 Nov 14, 2024

Choose a reason for hiding this comment

trjExpensify Nov 14, 2024

Choose a reason for hiding this comment

trjExpensify Nov 14, 2024

Choose a reason for hiding this comment

shawnborton commented Nov 14, 2024

trjExpensify commented Nov 14, 2024

trjExpensify commented Nov 14, 2024

hungvu193 commented Nov 14, 2024

trjExpensify commented Nov 14, 2024

This comment has been minimized.

trjExpensify commented Nov 14, 2024

shubham1206agra commented Nov 14, 2024

hungvu193 commented Nov 14, 2024

hungvu193 commented Nov 14, 2024

trjExpensify commented Nov 14, 2024 • edited Loading

trjExpensify commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

trjExpensify commented Nov 14, 2024

mountiny left a comment

Choose a reason for hiding this comment

shubham1206agra commented Nov 14, 2024 • edited Loading

shubham1206agra commented Nov 14, 2024

shubham1206agra commented Nov 14, 2024

shubham1206agra commented Nov 14, 2024

trjExpensify commented Nov 14, 2024

hungvu193 commented Nov 15, 2024

hungvu193 commented Nov 15, 2024

hungvu193 commented Nov 15, 2024 • edited Loading

trjExpensify commented Nov 15, 2024

shubham1206agra commented Nov 15, 2024

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Nov 18, 2024

OSBotify commented Nov 18, 2024

github-actions bot commented Nov 19, 2024

hungvu193 commented Nov 19, 2024

mvtglobally commented Nov 20, 2024

github-actions bot commented Nov 21, 2024

hungvu193 commented Nov 14, 2024 •

edited

Loading

trjExpensify commented Nov 14, 2024 •

edited

Loading

shubham1206agra commented Nov 14, 2024 •

edited

Loading

hungvu193 commented Nov 15, 2024 •

edited

Loading