Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOU Participant page search validation #5254

Merged
merged 5 commits into from
Oct 18, 2021
Merged

IOU Participant page search validation #5254

merged 5 commits into from
Oct 18, 2021

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Sep 14, 2021 •
edited
Loading

Details

Added search validation for IOU Participant Pages also like as it is in New Chat/Group search pages

Fixed Issues

$ #4690

Tests & QA Steps

  1. Click ➕ FAB icon.
  2. Select New IOU Request/Split options
  3. Enter invalid search input

Fix

A validation message will show for invalid inputs on IOU participant pages search also.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-09-15 at 12 47 58 AM

Mobile Web

Simulator Screen Shot - iPhone 11 - 2021-09-15 at 00 50 03

Desktop

Screenshot 2021-09-15 at 12 48 29 AM

iOS

Simulator Screen Shot - iPhone 12 - 2021-09-15 at 00 52 13

Android

Screenshot_1631647362

@Santhosh-Sellavel Santhosh-Sellavel marked this pull request as ready for review September 15, 2021 03:21
@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner September 15, 2021 03:21
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team September 15, 2021 03:21
tgolen
tgolen previously approved these changes Sep 15, 2021
View reviewed changes
src/libs/OptionsListUtils.js Show resolved Hide resolved
@Santhosh-Sellavel Santhosh-Sellavel changed the title [WIP] IOU Participant page search validation IOU Participant page search validation Sep 15, 2021
@kadiealexander
Copy link
Contributor

Hi @Santhosh-Sellavel, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.

tgolen
tgolen previously approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I'm approving, but won't merge right now since it's on HOLD.

parasharrajat
parasharrajat suggested changes Oct 7, 2021
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments below, another issue that I have found is when the maximum number of users is selected (and we hide the contact list), now if you search for something and the user is not in the hidden list, then an error is shown which is bad.
image

src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsRequest.js Outdated Show resolved Hide resolved
src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsSplit.js Outdated Show resolved Hide resolved
@parasharrajat
Copy link
Member

@Santhosh-Sellavel Video.

output_file.mp4

@Santhosh-Sellavel
Copy link
Collaborator Author

@Santhosh-Sellavel Video.

output_file.mp4

Ok, I get it now.

parasharrajat
parasharrajat suggested changes Oct 8, 2021
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change and otherwise looks good now.

src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsSplit.js Outdated Show resolved Hide resolved
parasharrajat
parasharrajat approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests well. Ready for final review after n6-hold is lifted.

@Santhosh-Sellavel Santhosh-Sellavel changed the title IOU Participant page search validation [Hold N6] IOU Participant page search validation Oct 10, 2021
@marcaaron marcaaron changed the title [Hold N6] IOU Participant page search validation IOU Participant page search validation Oct 18, 2021
@marcaaron marcaaron merged commit a142eb2 into Expensify:main Oct 18, 2021
@marcaaron marcaaron removed the n6-hold label Oct 18, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parasharrajat parasharrajat parasharrajat approved these changes

@marcaaron marcaaron marcaaron approved these changes

@tgolen tgolen tgolen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Santhosh-Sellavel @kadiealexander @parasharrajat @OSBotify @tgolen @marcaaron