Update CONTRIBUTING.md #5257
Merged
Update CONTRIBUTING.md #5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 40 added "(you must be signed in to Upwork to view jobs)" Line 44 removed "the [Upwork job list](https://www.upwork.com/ab/jobs/search/?q=Expensify%20React%20Native&sort=recency&user_location_match=2) or" because GH is the source of truth, no job in Upwork won't be in GH, and you need an account to view in Upwork so we don't want to send there. Line 46 removed "or [Upwork job list](https://www.upwork.com/ab/jobs/search/?q=Expensify%20React%20Native&sort=recency&user_location_match=2)" same reasoning as above.
HorusGoul
approved these changes
Sep 15, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
27 tasks
|
🚀 Deployed to staging by @HorusGoul in version: 1.0.98-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 40 added "(you must be signed in to Upwork to view jobs)"
Line 44 removed "the Upwork job list or" because GH is the source of truth, no job in Upwork won't be in GH, and you need an account to view in Upwork so we don't want to send there.
Line 46 removed "or Upwork job list" same reasoning as above.
Details
Fixed Issues
$ GH_LINK
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android