Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4902 fix crash #5261

Conversation

dklymenk
Copy link
Contributor

@Beamanator

Details

This PR should fix a crash reported by @Beamanator https://expensify.slack.com/archives/C01GTK53T8Q/p1631706401300500. The issue is caused by my previous PR #5167

Fixed Issues

Tests / QA Steps

Assume that timezone A and timezone B have the same UTC offset, but different names. Example: Europe/Moscow and Europe/Istanbul (both are UTC +3).

  1. Log in with account A
  2. Go to profile settings
  3. Manually set timezone to timezone A
  4. Log in with account B
  5. Go to profile settings
  6. Manually set timezone to timezone B
  7. Open chat with account A
  8. The recipients local time should not be shown since both timezones have the same UTC offset.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@dklymenk dklymenk requested a review from a team as a code owner September 15, 2021 13:39
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team September 15, 2021 13:39
@Beamanator Beamanator self-requested a review September 15, 2021 13:44
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 thanks man. Will merge after tests pass

@Beamanator Beamanator merged commit 1f0436c into Expensify:main Sep 15, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@dklymenk dklymenk deleted the 4902-fix-crash-caused-by-undefined-timezone branch September 15, 2021 14:42
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.0.98-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.0.99-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants