chg: Workspace Edit Page

[parasharrajat]

Details

1. Change the Form Input Field.
2. Added the error message.
3. Refactor to fix the issue.

Fixed Issues

$ #5194
$ #5783
$ #5777

Tests | QA Steps

1. Navigate to settings
2. Click on a workspace
3. Click on the workspace avatar to edit
4. Delete the name and save.
5. You should error below the field.
6. Now add a new Name and save and save should happen smoothly.

Please test all the three issues attached.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web | Desktop

Mobile Web

iOS

Android

[kadiealexander]

Hi @parasharrajat, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.

[parasharrajat]

@johnmlee101

Workspace Settings Page updates in N6 and thus the issue #5194 no more exists.

But It covers other existing bugs which was not fixed.

• Pressing submits when the image is still uploading.
• Clear the Name and pressing the Save, submits the form even if there is an error.

Secondly, I am fixing another issue in this PR as I don't want to create another PR for the small issue #5783.

[parasharrajat]

There is another issue that I will take care of in this one. #5777.

But I want to know the best solution possible for that.

1. Should we block the navigation when the image is uploading and show an alert?
2. Gracefully hide handle the Policy. i.e. Set the isAvatarUploading: false and Block the state update.

[johnmlee101]

Should we block the navigation when the image is uploading and show an alert?

I think just disabling the inputs until finished is fine.

Gracefully hide handle the Policy. i.e. Set the isAvatarUploading: false and Block the state update.

and yeah blocking the state update makes the most sense.

[parasharrajat]

@johnmlee101 This is ready for review.

[parasharrajat]

Gentle bump @johnmlee101 for review.

[johnmlee101]

One comment, but if you think it should be a NAB lmk

[parasharrajat]

@johnmlee101 Answered your question. Let's merge otherwise.

[OSBotify]

🚀 Deployed to staging by @johnmlee101 in version: 1.1.8-23 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅