-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Retain cursor on form submit #5274
Conversation
Hi @mananjadhav, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting. |
Thanks for notifying @kadiealexander. Nothing to apologise for :) Let me know if we can help in anyway for the upcoming release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I will add HOLD into the title until we are done with the release, just in case I would accidentally want to merge this 😅
Hi @mananjadhav, the Although this PR is quite small and simple, I would prefer if we could always merge Thank you very much and I hope it won't take too long. Thank you for your patience 🙇 |
…gnin-page-focus
@mountiny PR updated with main merged. |
Thank you @mananjadhav, waiting for the tests to pass :) |
@mananjadhav Thank you for your patience and working on this! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved it already before and no changes were added since.
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
@mountiny PR for the cursor issue.
Details
blurOnSubmit
for thePasswordForm
Fixed Issues
$ #5191
Tests
QA Steps
Tested On
Screenshots
Web
Screen.Recording.2021-09-16.at.1.01.47.AM.mov
Mobile Web
Screen.Recording.2021-09-16.at.1.14.32.AM.mov
Desktop
Screen.Recording.2021-09-16.at.1.04.56.AM.mov
iOS
Screen.Recording.2021-09-16.at.1.11.30.AM.mov
Android
Screen.Recording.2021-09-16.at.1.22.31.AM.mov