Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert PR #5037 #5288

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Revert PR #5037 #5288

merged 3 commits into from
Sep 16, 2021

Conversation

luacmartins
Copy link
Contributor

This PR reverts changes made here #5037

Details

Fixed Issues

$ #5285

Tests

None

QA Steps

None.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@luacmartins luacmartins self-assigned this Sep 16, 2021
@luacmartins luacmartins requested a review from a team as a code owner September 16, 2021 02:04
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team September 16, 2021 02:05
@luacmartins luacmartins merged commit d7e7d77 into main Sep 16, 2021
@luacmartins luacmartins deleted the cmartins-revert-5037 branch September 16, 2021 02:54
github-actions bot pushed a commit that referenced this pull request Sep 16, 2021
@luacmartins
Merge pull request #5288 from Expensify/cmartins-revert-5037
54bc1fa 
Revert PR #5037

(cherry picked from commit d7e7d77)
This was referenced Sep 16, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @luacmartins in version: 1.0.99-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Sep 20, 2021
Closed
31 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.0.99-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.0.99-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.0-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcaaron marcaaron marcaaron approved these changes

@MariaHCD MariaHCD Awaiting requested review from MariaHCD

Assignees

@luacmartins luacmartins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luacmartins @OSBotify @marcaaron