Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup errors for Google Tag Manager #52934

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Cleanup errors for Google Tag Manager #52934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70b5c0c
log when thirdPartyScripts loads for debugging
arosiclair Nov 21, 2024
1908fd9
fix MIME type
arosiclair Nov 21, 2024
bec24d7
fix script path
arosiclair Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
<link rel="shortcut icon" id="favicon" href="/favicon.png">
<% if (htmlWebpackPlugin.options.useThirdPartyScripts) { %>
<!-- Third party scripts -->
<script async="" src="thirdPartyScripts.js"></script>
<script type="text/javascript" async="" src="/thirdPartyScripts.js"></script>
<!-- End Third party scripts -->
<% } %>
<link rel="manifest" href="/manifest.json" />
Expand Down
2 changes: 2 additions & 0 deletions web/thirdPartyScripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,3 +153,5 @@ window['_fs_namespace'] = 'FS';
}),
(g._v = '2.0.0'));
})(window, document, window._fs_namespace, 'script', window._fs_script);

console.log('thirdPartyScripts.js loaded');
Loading