-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Update redirects.csv #53673
[No QA] Update redirects.csv #53673
Conversation
@NikkiWines Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
A preview of your ExpensifyHelp changes have been deployed to https://7ef6c797.helpdot.pages.dev ⚡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RachCHopkins https://help.expensify.com/articles/new-expensify/expenses-&-payments/Export-download-expenses.md doesn't seem to load anything on helpDot
docs/redirects.csv
Outdated
@@ -607,3 +607,4 @@ https://help.expensify.com/articles/expensify-classic/spending-insights/Other-Ex | |||
https://help.expensify.com/articles/expensify-classic/travel/Edit-or-cancel-travel-arrangements,https://help.expensify.com/articles/expensify-classic/travel/Book-with-Expensify-Travel | |||
https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Create-and-Pay-Bills,https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Receive-and-Pay-Bills | |||
https://help.expensify.com/articles/expensify-classic/settings/Set-Notifications,https://help.expensify.com/articles/expensify-classic/settings/Email-Notifications | |||
https://help.expensify.com/articles/new-expensify/expenses-&-payments/Export-expenses,https://help.expensify.com/articles/new-expensify/expenses-&-payments/Export-download-expenses.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it doesn't look like any of the other redirect links use .md
here, are you sure that's correct?
Sorry, fixed @NikkiWines - it may not go to anything yet because the page is not on prod, but it has to be done before #53619 can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not do everything in the other PR? |
Sorry @Gonals I'm a bit of a novice with github, I don't actually know how to put two different files on one PR. |
🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.75-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.75-6 🚀
|
Explanation of Change
Name change of help doc for #53619
Fixed Issues
https://github.com/Expensify/Expensify/issues/442537
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videosundefined