Fix badly positioned screen with autofocus #53699

jnowakow · 2024-12-06T12:16:28Z

Explanation of Change

Composer isn't displayed on first render of ReportScreen when navigating to new chat. It renders when there are already components on screen. In such situation Composer has autoFocus set to true which opens keyboard automatically when it renders. But since it's not first render it seems that some calculation breaks on android hybrid app.

Fixed Issues

$ #53185
PROPOSAL: N/A

Tests

Click Start new chat.
Search for a person that you has no conversation history and hadn't search for in this session
Click that person to open chat.
Verify that input is focused and there is no blank space between keyboard and input

Verify that no errors appear in the JS console

Offline tests

Same as in Tests

QA Steps

Same as in Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Hybrid:

hybrid-app.mov

ND:

android-standalone.mov

Android: mWeb Chrome

N/A

iOS: Native

Hybrid:

iOS-hybrid.mov

ND:

ios-ND.mov

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-12-06T12:16:33Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-12-09T00:08:58Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

mountiny · 2024-12-09T00:09:15Z

@jnowakow Can you please fill in the QA steps too and add videos? You have not added any

@DylanDylann can you please test this one? thanks!

jnowakow · 2024-12-09T11:32:30Z

@mountiny I've updated the comment (I've had problems with running ND on mobile browsers so I'll try to record those videos later)

DylanDylann · 2024-12-10T09:47:24Z

I can only test on ND, this change looks safe for ND

DylanDylann · 2024-12-10T09:59:12Z

@jnowakow The app is crashed when going to an invalid report URL

Screen.Recording.2024-12-10.at.16.58.17.mov

jnowakow · 2024-12-10T11:03:35Z

@DylanDylann please check once more

github-actions · 2024-12-10T12:02:19Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2024-12-10T12:26:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53699/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53699/NewExpensify.dmg	https://53699.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

DylanDylann · 2024-12-11T10:28:09Z

@jnowakow We have a bit of a difference between the main branch when the screen is loading

Main branch

Screen.Recording.2024-12-11.at.17.26.16.mov

Current PR

Screen.Recording.2024-12-11.at.17.27.44.mov

jnowakow · 2024-12-11T10:39:10Z

@DylanDylann I can't see the difference. Are you sure you it's not the same recording two times?

DylanDylann · 2024-12-11T10:42:36Z

Ops, wrong video

DylanDylann · 2024-12-11T10:43:42Z

@jnowakow I already updated again

jnowakow · 2024-12-11T10:46:38Z

@DylanDylann yeah, now I see the difference :)

mountiny · 2024-12-13T17:36:20Z

@jnowakow any update here?

jnowakow · 2024-12-16T07:00:44Z

@mountiny I worked on it but it's hard to debug. It's caused by focus being called in one of many rerenders and it causes whole screen to go up by the height of the keyboard.

I think I'll try to find some workaround (and maybe clean up a bit ReportScreen)

github-actions · 2024-12-18T00:14:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53699/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53699/NewExpensify.dmg	https://53699.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

DylanDylann · 2024-12-18T04:48:28Z

src/components/Composer/implementation/index.native.tsx

+            // There are cases in hybird app on android that screen goes up when there is autofocus on keyboard. (e.g. https://github.com/Expensify/App/issues/53185)
+            // Workaround for this issue is to maunally focus keyboard after it's acutally rendered which is done by useAutoFocusInput hook.
+            // */
+            autoFocus={Platform.OS !== 'android' ? autoFocus : false}


@jnowakow Because we already used useAutoFocusInput, could we remove this line?

Suggested change

autoFocus={Platform.OS !== 'android' ? autoFocus : false}

Without this line iOS doesn't work. It's quite strange issue

ios-without-autofocus.mov

@jnowakow Thanks. It doesn't work on IOS only. I think it relates to this problem: facebook/react-native#47576

Sounds like it may be this problem

jnowakow · 2024-12-18T09:29:31Z

@mountiny Build and deploy hybrid apps for testing is a new workflow for building adhoc hybrid apps and I wanted to test it here but I see it's to early and I have to fix somethings

DylanDylann · 2024-12-18T09:57:24Z

@jnowakow We avoid using Platform checking on our codebase. Could you apply this pattern to this PR?

https://github.com/Expensify/App?tab=readme-ov-file#platform-specific-file-extensions

jnowakow · 2024-12-18T13:23:57Z

@DylanDylann I can see some usages of Platform.OS across the App and I think duplicating file to change one line would be very confusing. But I can see that useAutoFocusInput hook was added to fix Android specific issue so I can check if iOS works correctly without this hook. If yes it would make sense to separate implementation between iOS and Android so it's clear that we handle autoFocus in a different way on both platforms

mountiny · 2024-12-19T00:14:36Z

What is next for this pr?

DylanDylann · 2024-12-19T03:45:00Z

@mountiny Do you agree with this?

DylanDylann · 2024-12-19T04:04:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-19.at.18.19.23.mov

Android: mWeb Chrome

Screen.Recording.2024-12-10.at.16.53.56.mov

iOS: Native

Screen.Recording.2024-12-19.at.18.18.09.mov

iOS: mWeb Safari

Screen.Recording.2024-12-10.at.16.45.43.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-10.at.16.53.29.mov

MacOS: Desktop

Screen.Recording.2024-12-10.at.16.48.31.mov

jnowakow · 2024-12-19T09:46:43Z

@DylanDylann I've checked iOS on hybrid app without useAutoFocusInput hook and it works correctly without it. So I've created .andoid.ts and .ios.ts files with different autoFocus handling.

@mountiny I think this workaround fixes the issue so we can proceed it. I would check if it also fixes #53571 but I'm not able to reproduce it locally

DylanDylann · 2024-12-19T10:00:15Z

@jnowakow Ops, It is not my mean

DylanDylann · 2024-12-19T10:02:13Z

Hmmm, It is so minor. Could you please revert the latest commit and use getPlatform function

jnowakow · 2024-12-19T11:03:37Z

@DylanDylann done

github-actions · 2024-12-19T13:37:49Z

🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2024-12-19T14:10:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53699/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

mountiny

Thanks

OSBotify · 2024-12-19T17:20:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-23T20:57:28Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	cancelled 🔪
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

github-actions · 2024-12-23T21:41:24Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-23T21:48:54Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T00:04:39Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T00:52:18Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T19:42:25Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T19:59:21Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-26T20:26:36Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Fix badly posiotioned screen with autofocus

f30f900

jnowakow requested a review from a team as a code owner December 6, 2024 12:16

melvin-bot bot requested a review from DylanDylann December 6, 2024 12:16

melvin-bot bot removed the request for review from a team December 6, 2024 12:16

jnowakow mentioned this pull request Dec 6, 2024

[PAID] Hybrid - Android - Group - Compose box is displayed floating when creating group chat #53185

Closed

8 tasks

mountiny assigned jnowakow Dec 9, 2024

mountiny self-requested a review December 9, 2024 00:08

mountiny added the Ready To Build label Dec 9, 2024

This comment has been minimized.

Sign in to view

Merge branch 'main' into fix-badly-positioned-screen-with-input

824baba

jnowakow added 2 commits December 10, 2024 11:17

Merge branch 'main' into fix-badly-positioned-screen-with-input

ff8e077

Fix crash when navigating to not existing chat

e02a770

jnowakow added 2 commits December 16, 2024 12:34

Merge branch 'main' into fix-badly-positioned-screen-with-input

3d81a3a

Merge branch 'main' into fix-badly-positioned-screen-with-input

013d471

DylanDylann reviewed Dec 18, 2024

View reviewed changes

Use getPlatform instead Platform.OS

8f6fbfc

jnowakow force-pushed the fix-badly-positioned-screen-with-input branch from dd8e0a6 to 8f6fbfc Compare December 19, 2024 11:03

DylanDylann approved these changes Dec 19, 2024

View reviewed changes

mountiny approved these changes Dec 19, 2024

View reviewed changes

mountiny merged commit 3ff7c74 into Expensify:main Dec 19, 2024
17 checks passed

jnowakow mentioned this pull request Dec 20, 2024

[$250] Hybrid App - Spacing above keyboard and status bar overlap on deeplinking to user with no chat #53571

Open

8 tasks

github-actions bot mentioned this pull request Dec 23, 2024

Deploy Checklist: New Expensify 2024-12-23 #54476

Closed

Fix badly positioned screen with autofocus #53699

Fix badly positioned screen with autofocus #53699

Conversation

jnowakow commented Dec 6, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 6, 2024

github-actions bot commented Dec 9, 2024

mountiny commented Dec 9, 2024

This comment has been minimized.

jnowakow commented Dec 9, 2024

DylanDylann commented Dec 10, 2024 • edited Loading

DylanDylann commented Dec 10, 2024

jnowakow commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

DylanDylann commented Dec 11, 2024 • edited Loading

Main branch

Current PR

jnowakow commented Dec 11, 2024

DylanDylann commented Dec 11, 2024

DylanDylann commented Dec 11, 2024

jnowakow commented Dec 11, 2024

mountiny commented Dec 13, 2024

jnowakow commented Dec 16, 2024

github-actions bot commented Dec 18, 2024

DylanDylann Dec 18, 2024

Choose a reason for hiding this comment

jnowakow Dec 18, 2024

Choose a reason for hiding this comment

DylanDylann Dec 18, 2024

Choose a reason for hiding this comment

jnowakow Dec 18, 2024

Choose a reason for hiding this comment

jnowakow commented Dec 18, 2024

DylanDylann commented Dec 18, 2024

jnowakow commented Dec 18, 2024 • edited Loading

mountiny commented Dec 19, 2024

DylanDylann commented Dec 19, 2024

DylanDylann commented Dec 19, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jnowakow commented Dec 19, 2024 • edited Loading

DylanDylann commented Dec 19, 2024

DylanDylann commented Dec 19, 2024

jnowakow commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 19, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 26, 2024

jnowakow commented Dec 6, 2024 •

edited

Loading

DylanDylann commented Dec 10, 2024 •

edited

Loading

DylanDylann commented Dec 11, 2024 •

edited

Loading

jnowakow commented Dec 18, 2024 •

edited

Loading

DylanDylann commented Dec 19, 2024 •

edited

Loading

jnowakow commented Dec 19, 2024 •

edited

Loading