Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generic bank icon for connected accounts #5861

Merged
merged 11 commits into from
Oct 16, 2021
Merged

Update generic bank icon for connected accounts #5861

merged 11 commits into from
Oct 16, 2021

Conversation

nickmurray47
Copy link
Contributor

@nickmurray47 nickmurray47 commented Oct 14, 2021 •
edited
Loading

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180970

Tests / QA

  1. With a brand-new account, create a new workspace on new.e
  2. Go to the workspace and click "Get started"
  3. Add an OPEN verified bank account following SO step 3.
  4. Go to the list of connected payment methods on the workspace
  5. Verify the new icon is in place

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-10-14 at 3 22 42 PM

Mobile Web

Desktop

iOS

Android

@nickmurray47 nickmurray47 self-assigned this Oct 14, 2021
@nickmurray47 nickmurray47 requested a review from a team as a code owner October 14, 2021 22:18
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team October 14, 2021 22:19
@nickmurray47 nickmurray47 changed the title Update default bank icon Update generic bank icon Oct 14, 2021
@nickmurray47 nickmurray47 changed the title Update generic bank icon Update generic bank icon for connected accounts Oct 15, 2021
@nickmurray47
Copy link
Contributor Author

ready to go

TomatoToaster
TomatoToaster suggested changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@TomatoToaster TomatoToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one linter issue but otherwise LGTM!

src/components/Icon/BankIcons.js Outdated Show resolved Hide resolved
TomatoToaster
TomatoToaster reviewed Oct 15, 2021
View reviewed changes
src/components/Icon/BankIcons.js
// For default icons the icon size should not be set.
if (![CreditCard, Bank].includes(bankIcon.icon)) {
// For default Credit Card icon the icon size should not be set.
if (![CreditCard].includes(bankIcon.icon)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: since it's just this one now, we could make this bankIcon.icon !== CreditCard

Update BankIcons.js
0919e68 
Add in semi-colom
@nickmurray47
Copy link
Contributor Author

updated!

@TomatoToaster TomatoToaster merged commit d8c5ee0 into main Oct 16, 2021
@TomatoToaster TomatoToaster deleted the nmurray-update-default-bank-icon branch October 16, 2021 05:36
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @TomatoToaster in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomatoToaster TomatoToaster TomatoToaster approved these changes

Assignees

@nickmurray47 nickmurray47

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickmurray47 @OSBotify @TomatoToaster