-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: login page error #5864
fix: login page error #5864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me Rajat, great job. I will give it a test later as we will approach the hold to be lifted.
@mountiny This is ready. |
@parasharrajat Thank you! i have tested for the US number with the dashes and the error then thinks it is an email: I know this is one edge case, but do you think we could maybe add some other Regex, which would check for this type of phone number format (with parenthesis and dashes)? It might be helpful and it should not introduce too much complexity. |
Ok. I still don't think this how it should be but I will add it. |
@parasharrajat Feel free to discuss it before working on it, I am not sure if I understood correctly your previous comment about it. sorry for the confusion. My point of view is, that simply from UX perspective, when user feeds something like this, they are clearly trying to add a phone number, but we will tell them it is a wrong email. I know it is not a big deal as it is edge case, but I think it is better UX if we catch this too (if we don't introduce some other regression by trying to do so of course). |
Thanks for putting up a discussion. @mountiny There are a couple of reasons, I don't feel that we should do this.
My suggestion is to improve error detection. as you can clearly see that this is a number. but the error says email. I think we remove the So If the match failed the input is the wrong email. |
I totally agree with this and that is what I am suggesting 😅 I am sorry if you have understood something else. Let's make needed changes, so that if user adds phone number with |
I didn't see the half message after the image. Lols. Sorry. |
Haha, no problem at all. Glad we understood each other now :) |
@mountiny Changes pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works well at least for the scenarios I could think of :)
Great job @parasharrajat
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Details
Fixed Issues
$ #5821
Tests | QA Steps
Tested On
Screenshots
Web | Mobile Web | Desktop | Android | IOS
output_file.mp4