Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-QA] Refactor duplicated personalDetailsPropTypes #5929

Merged
merged 3 commits into from
Oct 19, 2021

Conversation

Julesssss
Copy link
Contributor

Details

Simply replaces the duplicated PropType with the previously defined file.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/181507

Tests

N/A. I tested many areas of the app for regressions. Testing will be covered by the regular deploy checklist regression testing.

QA Steps

N/A

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-10-18 at 18 02 54

Mobile Web

Screenshot_1634576937

Desktop

iOS

Android

Screenshot_1634576817

@Julesssss Julesssss requested a review from a team as a code owner October 18, 2021 17:15
@Julesssss Julesssss self-assigned this Oct 18, 2021
@MelvinBot MelvinBot requested review from Gonals and removed request for a team October 18, 2021 17:16
@Gonals Gonals merged commit 1545c82 into main Oct 19, 2021
@Gonals Gonals deleted the jules-refactorPersonalDetailsPropType branch October 19, 2021 14:17
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Gonals in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants