Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA] Small Refactor #5937

Merged
merged 1 commit into from
Oct 19, 2021
Merged

[NO QA] Small Refactor #5937

merged 1 commit into from
Oct 19, 2021

Conversation

parasharrajat
Copy link
Member

cc: @marcaaron

Details

Correct bad naming as part of #5131

@parasharrajat parasharrajat requested a review from a team as a code owner October 18, 2021 22:11
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team October 18, 2021 22:11
@parasharrajat parasharrajat mentioned this pull request Oct 18, 2021
Merged
5 tasks
marcaaron
marcaaron approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for catching this. I guess it works either way but good to have the naming consistent :)

@MariaHCD MariaHCD merged commit 64cb863 into Expensify:main Oct 19, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@parasharrajat parasharrajat deleted the fix-navigation branch October 19, 2021 07:42
@OSBotify OSBotify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @MariaHCD in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariaHCD MariaHCD MariaHCD approved these changes

@marcaaron marcaaron marcaaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parasharrajat @OSBotify @MariaHCD @marcaaron