Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added minimum phone number length #5938

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Added minimum phone number length #5938

merged 1 commit into from
Oct 19, 2021

Conversation

Luke9389
Copy link
Contributor

@Luke9389 Luke9389 commented Oct 18, 2021 •
edited
Loading

Details

Just adding a phone number minimum length for use in our ValidationUtils.isValidPhoneWithSpecialChars method.

Fixed Issues

$ #5936

Tests / QA Steps

  1. Sign in to New Dot with a new account
  2. Create a new workspace
  3. Connect a new bank account
  4. Routing number: 123123123
    Account Number: 1111222233331111
  5. Hit enter. When you're on the Company Information page, input a phone number that's less than 5 digits long.
  6. Verify that you see the error under the 'phone number' field and that the border of that field turns red.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@Luke9389 Luke9389 requested a review from a team as a code owner October 18, 2021 23:24
@Luke9389 Luke9389 self-assigned this Oct 18, 2021
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team October 18, 2021 23:24
@Jag96 Jag96 merged commit 9dc6877 into main Oct 19, 2021
@Jag96 Jag96 deleted the luke-min-phone-length-vba branch October 19, 2021 16:39
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mvtglobally mvtglobally mentioned this pull request Oct 27, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

Assignees

@Luke9389 Luke9389

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luke9389 @OSBotify @Jag96