Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Cleanup unnecessary usages of compose() #6001

Merged
merged 4 commits into from
Oct 25, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Oct 22, 2021

Details

Clean up incorrect usages of compose()

Fixed Issues

$ #6000

Tests / QA Steps

All of these changes should be syntax and shouldn't have any bearing on the app behavior.
Therefore, we just need to run regular regressions.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Oct 22, 2021
@marcaaron marcaaron marked this pull request as ready for review October 22, 2021 22:58
@marcaaron marcaaron requested a review from a team as a code owner October 22, 2021 22:58
@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team October 22, 2021 22:58
Copy link
Contributor

@marcochavezf marcochavezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 👍🏽

@marcochavezf marcochavezf merged commit cf3afd6 into main Oct 25, 2021
@marcochavezf marcochavezf deleted the marcaaron-composeCleanup branch October 25, 2021 16:58
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcochavezf in version: 1.1.8-19 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@roryabraham roryabraham changed the title Cleanup unnecessary usages of compose() [No QA] Cleanup unnecessary usages of compose() Oct 25, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants