Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Update propTypes files to use camelCase #6005

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Oct 22, 2021

Details

Style change to make all propTypes modules use camelCase.

Fixed Issues

$ #6004

Tests / QA Steps

Test app for general regressions. Make sure all things are possible. This is a style change so there is nothing in particular to test.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@marcaaron marcaaron self-assigned this Oct 22, 2021
@marcaaron marcaaron marked this pull request as ready for review October 22, 2021 23:15
@marcaaron marcaaron requested a review from a team as a code owner October 22, 2021 23:15
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team October 22, 2021 23:16
Copy link
Contributor

@TomatoToaster TomatoToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcaaron
Copy link
Contributor Author

I know we are on a feature freeze atm and avoiding risk, but despite the high file count here I'd argue this is very low risk since no behavior was changed. Going for the merge!

@marcaaron marcaaron merged commit 3a58a6e into main Oct 25, 2021
@marcaaron marcaaron deleted the marcaaron-fixPropTypes branch October 25, 2021 17:54
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.1.8-20 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@roryabraham roryabraham changed the title Update propTypes files to use camelCase [No QA] Update propTypes files to use camelCase Oct 25, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants