Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Update App Readme to include flow chart. Fix error in style guide. #6008

Merged
merged 4 commits into from
Oct 22, 2021
Merged

[No QA] Update App Readme to include flow chart. Fix error in style guide. #6008

merged 4 commits into from
Oct 22, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Oct 22, 2021 •
edited
Loading

Details

  • Fixes a mistake where it is suggested to use _.get() we still prefer lodashGet().
  • Adds a flow chart to show off the Expensify/App architecture flow for the visual learners

Fixed Issues

N/A

Tests / QA Steps

❌

@marcaaron marcaaron self-assigned this Oct 22, 2021
@marcaaron marcaaron changed the title Update App Readme to include flow chart. Fix error in style guide. [No QA] Update App Readme to include flow chart. Fix error in style guide. Oct 22, 2021
@marcaaron marcaaron marked this pull request as ready for review October 22, 2021 23:08
@marcaaron marcaaron requested a review from a team as a code owner October 22, 2021 23:08
@MelvinBot MelvinBot requested review from yuwenmemon and removed request for a team October 22, 2021 23:09
@yuwenmemon yuwenmemon merged commit 919c890 into main Oct 22, 2021
@yuwenmemon yuwenmemon deleted the marcaaron-updateReadme branch October 22, 2021 23:33
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @yuwenmemon in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenmemon yuwenmemon yuwenmemon approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcaaron @OSBotify @yuwenmemon