-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep link to add secondary login in OldDot #6176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me, great job on this not-so-small PR Carlos!
Passed the tests, merging! |
Damn! Forgot to put a hold on this one 😞 |
@luacmartins Yikes! Sorry about this, the QA steps worked for me so I have not thought of anything suspicious 😄 Approved the revert! |
🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀
|
Details
Copy changes to
Issue corporate cards
andConnect bank account
page and deep-linking toAdd secondary login
in OldDot.Fixed Issues
https://github.com/Expensify/Expensify/issues/182071 (partial)
Tests
@gmail.com
Settings > Account Details > Add secondary login
with the secondary login modal open.Settings > Select Workspace > Issue corporate cards
.Settings > Account Details > Add secondary login
with the secondary login modal open.QA Steps
Steps above.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android