Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep link to add secondary login in OldDot #6176

Merged
merged 10 commits into from
Nov 15, 2021

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Nov 2, 2021

Details

Copy changes to Issue corporate cards and Connect bank account page and deep-linking to Add secondary login in OldDot.

Fixed Issues

https://github.com/Expensify/Expensify/issues/182071 (partial)

Tests

  1. Create an account using a public domain, e.g @gmail.com
  2. Follow the steps in this SO to add an "OPEN" bank account.
  3. When you reach the last step, verify the following:
  • Copy

This bank account will be used to reimburse expenses, collect invoices, and pay bills all from the same account. Please add a work email address as a secondary login to enable the Expensify Card.

  • Button

Add work email address

  1. Click the button and verify that it opens new browser tab on OldDot and directs user to Settings > Account Details > Add secondary login with the secondary login modal open.
  2. Go back to NewDot and navigate to Settings > Select Workspace > Issue corporate cards.
  3. Verify that the following:
  • Copy

Add a work email address to issue unlimited Expensify Cards for your workspace members, as well as all of these incredible benefits:

Up to 2% cash back
Digital and physical cards
No personal liability
Customizable limits

  • Button

Add work email address

  1. Click the button and verify that it opens new browser tab on OldDot and directs user to Settings > Account Details > Add secondary login with the secondary login modal open.

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-1

web-2

Mobile Web

mweb-1

mweb-2

Desktop

desktop-1

desktop-2

iOS

ios-1

ios-2

Android

android-1

andorid-2

@luacmartins luacmartins self-assigned this Nov 2, 2021
@luacmartins luacmartins marked this pull request as ready for review November 15, 2021 23:02
@luacmartins luacmartins requested a review from a team as a code owner November 15, 2021 23:02
@MelvinBot MelvinBot requested review from mountiny and removed request for a team November 15, 2021 23:02
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me, great job on this not-so-small PR Carlos!

@mountiny
Copy link
Contributor

Passed the tests, merging!

@mountiny mountiny merged commit db0d4dd into main Nov 15, 2021
@mountiny mountiny deleted the cmartins-privateSecondaryLogin branch November 15, 2021 23:46
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @mountiny in version: 1.1.14-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@luacmartins
Copy link
Contributor Author

Damn! Forgot to put a hold on this one 😞
I was still waiting for this PR to go out https://github.com/Expensify/Web-Expensify/pull/32333. Gonna revert this PR until the Web-E one goes out.

@mountiny
Copy link
Contributor

@luacmartins Yikes! Sorry about this, the QA steps worked for me so I have not thought of anything suspicious 😄

Approved the revert!

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants