Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Fix blank page upon signing out #6240

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Nov 5, 2021

Details

When logging out, the first report in the report array is null for some reason. To prevent throwing this error, I am adding a check to make sure the report is not undefined.

cc @marktoman

Fixed Issues

$ #6239
$ #6228

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

BlankScreenAfterSignOut.mov

Mobile Web

Desktop

iOS

Android

@mountiny mountiny requested a review from a team November 5, 2021 13:08
@mountiny mountiny self-assigned this Nov 5, 2021
@MelvinBot MelvinBot requested review from cead22 and removed request for a team November 5, 2021 13:09
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@mountiny
Copy link
Contributor Author

mountiny commented Nov 5, 2021

Addis CP Staging label as this issue is existent on staging as well (the PR which introduced it is deployed to staging).

@mountiny
Copy link
Contributor Author

mountiny commented Nov 5, 2021

Adding @stitesExpensify for a review since you got assigned to the other deploy blocker which should be resolved by this PR. Thank you for a review 🙇

@madmax330 madmax330 merged commit f6e5fb5 into main Nov 5, 2021
@madmax330 madmax330 deleted the vit-fixDeployBlockerBlankPage branch November 5, 2021 15:10
github-actions bot pushed a commit that referenced this pull request Nov 5, 2021
[CP Staging] Fix blank page upon signing out

(cherry picked from commit f6e5fb5)
@OSBotify
Copy link
Contributor

OSBotify commented Nov 5, 2021

🚀 Cherry-picked to staging by @madmax330 in version: 1.1.14-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @madmax330 in version: 1.1.14-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.14-4 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants