Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #6241

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Update CONTRIBUTING.md #6241

merged 1 commit into from
Nov 5, 2021

Conversation

michaelhaxhiu
Copy link
Contributor

@michaelhaxhiu michaelhaxhiu commented Nov 5, 2021

  • Added a space because it's missing & I have ocd.
  • Added a few lines that basically clarify "implement" = deploying to production. If this feels super obvious to you as an engineer, then feel free to nix it.

This is a tiny change.

Added a space because it's missing & I have ocd.
@michaelhaxhiu michaelhaxhiu requested a review from a team as a code owner November 5, 2021 13:13
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team November 5, 2021 13:14

#### Proposing a job that Expensify hasn’t posted

In this scenario, it’s possible that you found a bug or enhancement that we haven’t posted to the [Github repository](https://github.com/Expensify/App/issues?q=is%3Aissue). This is an opportunity to propose a job, and (optionally) a solution. If it's a valid job proposal that we choose to implement — either internally or via an external contributor — then we will compensate you $250 for identifying and proposing the improvement. Note: If you get assigned the job you proposed **and** you complete the job, this $250 for identifying the improvement is *in addition to* the reward you will be paid for completing the job.
In this scenario, it’s possible that you found a bug or enhancement that we haven’t posted to the [Github repository](https://github.com/Expensify/App/issues?q=is%3Aissue). This is an opportunity to propose a job, and (optionally) a solution. If it's a valid job proposal that we choose to implement by deploying it to production — either internally or via an external contributor — then we will compensate you $250 for identifying and proposing the improvement. Note: If you get assigned the job you proposed **and** you complete the job, this $250 for identifying the improvement is *in addition to* the reward you will be paid for completing the job.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this change wanted as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok just reread the PR and it seems it was

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep!

@sketchydroide
Copy link
Contributor

Added a few lines that basically clarify "implement" = deploying to production. If this feels super obvious to you as an engineer, then feel free to nix it. I think this is ok, a clarification of what implementing is

@sketchydroide sketchydroide merged commit 97a933d into main Nov 5, 2021
@sketchydroide sketchydroide deleted the hax-readme-edit branch November 5, 2021 15:08
@OSBotify
Copy link
Contributor

OSBotify commented Nov 5, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @sketchydroide in version: 1.1.14-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants