Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted workspace create button click while workspace is created. #6280

Merged

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Nov 11, 2021

Details

Fixed Issues

$ #5573

Tests & QA Steps

  1. Click ➕ new button
  2. Select the New workspace option
  3. No quickly try to repeat the step 1 & 2
  4. New workspace option will be hidden now

Tested On

  • Web
  • Desktop
  • iOS
  • Android
  • Mobile Web

Screenshots

Web

Web.mov

Desktop

Desktop.mov

iOS

iOS.mp4

Android

Android.mov

Mobile Web

mWEB.mp4

@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner November 11, 2021 19:37
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team November 11, 2021 19:38
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and holding

@Julesssss Julesssss changed the title Restricted workspace create button click while workspace is created. [HOLD] Restricted workspace create button click while workspace is created. Nov 11, 2021
@mallenexpensify
Copy link
Contributor

Removed Company Offsite HOLD, feel free to merge @Julesssss

@Julesssss Julesssss changed the title [HOLD] Restricted workspace create button click while workspace is created. Restricted workspace create button click while workspace is created. Nov 16, 2021
@Julesssss Julesssss merged commit 0f2a11a into Expensify:main Nov 16, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants