Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPhoneX Landscape UI #6291

Merged
merged 2 commits into from
Nov 16, 2021
Merged

iPhoneX Landscape UI #6291

merged 2 commits into from
Nov 16, 2021

Conversation

kakajann
Copy link
Contributor

Details

Added SafeArea for iPhone X to prevent its notch from blocking the UI

Fixed Issues

$ #5926

Tests

N/A

QA Steps

Screen Shot 2021-11-13 at 8 48 49 AM

  1. Launch the app with iPhone X or newer models that have a notch.
  2. Rotate the phone to landscape mode
  3. Confirm all content is visible

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

iOS

Screen Shot 2021-11-13 at 8 49 38 AM

@kakajann kakajann requested a review from a team as a code owner November 13, 2021 03:53
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team November 13, 2021 03:53
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only issue I noticed was this pre-existing issue when you rotate from the chat list page (which is unrelated)

iPhoneRotation.mov

@Julesssss
Copy link
Contributor

I'm just confirming whether our hold ends this week or last week...

@Julesssss
Copy link
Contributor

Yep, we're holding until next week. Will merge then.

@mallenexpensify
Copy link
Contributor

Removed Company Offsite Hold, @Julesssss , feel free to merge

@Julesssss Julesssss merged commit c7e618c into Expensify:main Nov 16, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Julesssss
Copy link
Contributor

Hey @kakajann, we noticed a regression associated with this PR. Please submit a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants