Deep link to add secondary login in OldDot #6319
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,55 +1,70 @@ | ||
| import React from 'react'; | ||
| import {View} from 'react-native'; | ||
| import {withOnyx} from 'react-native-onyx'; | ||
| import Text from '../../../components/Text'; | ||
| import styles from '../../../styles/styles'; | ||
| import withLocalize, {withLocalizePropTypes} from '../../../components/withLocalize'; | ||
| import {Mail} from '../../../components/Icon/Expensicons'; | ||
| import {JewelBoxBlue} from '../../../components/Icon/Illustrations'; | ||
| import UnorderedList from '../../../components/UnorderedList'; | ||
| import WorkspaceSection from '../WorkspaceSection'; | ||
| import Navigation from '../../../libs/Navigation/Navigation'; | ||
| import {openOldDotLink} from '../../../libs/actions/Link'; | ||
| import {subscribeToExpensifyCardUpdates} from '../../../libs/actions/User'; | ||
| import ONYXKEYS from '../../../ONYXKEYS'; | ||
| import compose from '../../../libs/compose'; | ||
|
|
||
| const propTypes = { | ||
| ...withLocalizePropTypes, | ||
| }; | ||
|
|
||
| const WorkspaceCardVBANoECardView = props => ( | ||
| <> | ||
| <WorkspaceSection | ||
| title={props.translate('workspace.card.header')} | ||
| icon={JewelBoxBlue} | ||
| menuItems={[ | ||
| { | ||
| title: props.translate('workspace.card.addWorkEmail'), | ||
| onPress: () => { | ||
| Navigation.dismissModal(); | ||
| openOldDotLink('settings?param={"section":"account","openModal":"secondaryLogin"}'); | ||
| subscribeToExpensifyCardUpdates(); | ||
| }, | ||
| icon: Mail, | ||
| shouldShowRightIcon: true, | ||
| }, | ||
| ]} | ||
| > | ||
| <View style={[styles.mv4]}> | ||
| <Text>{props.translate('workspace.card.VBANoECardCopy')}</Text> | ||
| </View> | ||
|
|
||
| <UnorderedList | ||
| items={[ | ||
| props.translate('workspace.card.benefit1'), | ||
| props.translate('workspace.card.benefit2'), | ||
| props.translate('workspace.card.benefit3'), | ||
| props.translate('workspace.card.benefit4'), | ||
| ]} | ||
| /> | ||
| </WorkspaceSection> | ||
| {props.user.isCheckingDomain && ( | ||
| <Text style={[styles.m5, styles.formError]}> | ||
| {props.translate('workspace.card.checkingDomain')} | ||
| </Text> | ||
| )} | ||
| </> | ||
| ); | ||
|
|
||
| WorkspaceCardVBANoECardView.propTypes = propTypes; | ||
| WorkspaceCardVBANoECardView.displayName = 'WorkspaceCardVBANoECardView'; | ||
|
|
||
| export default compose( | ||
| withLocalize, | ||
| withOnyx({ | ||
| user: { | ||
| key: ONYXKEYS.USER, | ||
| }, | ||
| }), | ||
| )(WorkspaceCardVBANoECardView); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we use the same in
subscribeToUserEvents, can we consolidate those somehow? Also, is there a reason we don't need to check ifcurrentUserAccountIDexists in this function?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a one-time only subscription that happens when the user clicks the
Add work email addresslink. Adding it tosubscribeToUserEventswould subscribe users prematurely and unnecessarily.I didn't add the check because when the user subscribes to this event we should have a
currentUserAccountID. That is different fromsubscribeToUserEventsbecausesubscribeToUserEventsis called upon login and race conditions could causecurrentUserAccountIDto be undefined. With that being said, I'll add the check just to be safe.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks for the explanation!