-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: clicking on makerbadge does not mark comments as read #6328
Conversation
Where are the screenshots on mobile & desktop? :D |
on the way... 🚶♂️ Actually I was confused about this as we can't open the Url on other platforms except for M-web. But I will create clips for standard behaviour. |
Sorry to keep you waiting all set now. @Beamanator |
Thanks dude - no worries about the delay :D
True, do you know if the reported issue was also occurring on other devices? Either way it's nice to know it's not breaking existing functionality so thanks for the videos :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍 and tests well
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @Beamanator in version: 1.1.15-18 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
|
Details
Fixed Issues
$ #5807
Tests | QA Steps
Tested On
Screenshots
Web
output_file.mp4
Mobile Web
output_file.mp4
Desktop
output_file.mp4
iOS
Android
output_file.mp4