Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: clicking on makerbadge does not mark comments as read #6328

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Nov 16, 2021

Details

Fixed Issues

$ #5807

Tests | QA Steps

  1. Open two browsers.
  2. Login with Account A in browser A.
  3. Login with account B in browser B.
  4. Close app on browser B.
  5. Send message from account A from browser A to account B.
  6. Copy the report URL from browser a.
  7. Go to browser B.
  8. Paste the URL of the Report you copied.
  9. Scoll the list back to see the marker.
  10. Click on the MarkerBadge.
  11. Comments should be marked as read.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

output_file.mp4

Mobile Web

output_file.mp4

Desktop

output_file.mp4

iOS

Android

output_file.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner November 16, 2021 17:58
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team November 16, 2021 17:58
@parasharrajat parasharrajat changed the title Fix: clicking on makerbadge does not mark comments as 6read Fix: clicking on makerbadge does not mark comments as read Nov 16, 2021
@Beamanator
Copy link
Contributor

Where are the screenshots on mobile & desktop? :D

@parasharrajat
Copy link
Member Author

parasharrajat commented Nov 18, 2021

on the way... 🚶‍♂️ Actually I was confused about this as we can't open the Url on other platforms except for M-web. But I will create clips for standard behaviour.

@parasharrajat
Copy link
Member Author

Sorry to keep you waiting all set now. @Beamanator

@Beamanator
Copy link
Contributor

Thanks dude - no worries about the delay :D

Actually I was confused about this as we can't open the Url on other platforms except for M-web. But I will create clips for standard behaviour.

True, do you know if the reported issue was also occurring on other devices? Either way it's nice to know it's not breaking existing functionality so thanks for the videos :)

Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 and tests well

@Beamanator Beamanator merged commit 98c3595 into Expensify:main Nov 19, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants