Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove animations from the Popover menus #6333

Merged
merged 8 commits into from
Nov 22, 2021
Merged

Remove animations from the Popover menus #6333

merged 8 commits into from
Nov 22, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Nov 16, 2021 •
edited
Loading

Details

Fixed Issues

$ #6121

Tests

Tested All menus on the web.

QA Steps

  1. Go to staging.new.expensify.com and login.
  2. Click the + icon in a Group DM text input and verify the popup menu.
  3. Follow other menus as well.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

output_file.mp4

Mobile Web

output_file.mp4

iOS

output_file.mp4

Android

output_file.mp4

@parasharrajat parasharrajat marked this pull request as ready for review November 17, 2021 16:52
@parasharrajat parasharrajat requested a review from a team as a code owner November 17, 2021 16:52
@botify botify requested a review from Jag96 November 17, 2021 16:52
@MelvinBot MelvinBot removed the request for review from a team November 17, 2021 16:52
@parasharrajat
Copy link
Member Author

@Jag96 This is ready.

Jag96
Jag96 suggested changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one style update and one question

src/components/PopoverMenu/popoverMenuPropTypes.js Outdated Show resolved Hide resolved
src/components/Popover/popoverPropTypes.js Outdated Show resolved Hide resolved
src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js Show resolved Hide resolved
@parasharrajat
Copy link
Member Author

@Jag96 changes done.

@parasharrajat parasharrajat requested a review from Jag96 November 21, 2021 17:10
@Jag96 Jag96 merged commit 1814323 into Expensify:main Nov 22, 2021
@OSBotify OSBotify mentioned this pull request Nov 22, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Nov 29, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @Jag96