Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avatar warning for incorrect propType #6336

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Nov 16, 2021

Details

This PR fixes a warning where we are passing in the incorrect prop type for the Avatar component on the ReportDetailsPage

Fixed Issues

N/A

Tests/QA

  1. Log into an account and navigate to a room (e.g. #announce)
  2. Tap on the header to access the room details
  3. Confirm there is no console error, and that the icon appears

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web Mobile
image image

@Jag96 Jag96 self-assigned this Nov 16, 2021
@Jag96 Jag96 requested a review from a team as a code owner November 16, 2021 20:13
@MelvinBot MelvinBot requested review from aldo-expensify and removed request for a team November 16, 2021 20:14
Copy link
Contributor

@aldo-expensify aldo-expensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aldo-expensify aldo-expensify merged commit dc4f1f3 into main Nov 16, 2021
@aldo-expensify aldo-expensify deleted the joe-fix-avatar-warning branch November 16, 2021 23:32
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @aldo-expensify in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants