Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass translateX prop to TextInput component #6341

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Pass translateX prop to TextInput component #6341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/ExpensiTextInput/BaseExpensiTextInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ class BaseExpensiTextInput extends Component {
onBlur={this.onBlur}
onChangeText={this.setValue}
onPressOut={this.props.onPress}
translateX={this.props.translateX}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jag96 Just want to know where did you get to know about this prop? It's not in docs...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a deprecated view prop: https://reactnative.dev/docs/transforms#decomposedmatrix-rotation-scalex-scaley-transformmatrix-translatex-translatey

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only knew about it because we've used it in other parts of the app, I wasn't aware it was deprecated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.

/>
</View>
</TouchableWithoutFeedback>
Expand Down