Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated copy for Issue corporate cards page #6346

Merged
merged 2 commits into from
Nov 20, 2021

Conversation

PrashantMangukiya
Copy link
Contributor

@PrashantMangukiya PrashantMangukiya commented Nov 17, 2021

@roryabraham PR is ready for review.

Details

Updated text/copy on Issue Corporate Card page for both pre and post card enablement.

Fixed Issues

$ #6316

Tests | QA Steps

  1. Click your avatar
  2. Click into a Workspace
  3. Click Issue corporate cards

QA: Now it will show updated text/copy (for both pre and post card enablement) as shown as under:

For Pre Enablement:

Connect a bank account to issue Expensify Cards to your workspace members, and access these incredible benefits and more:

Post Enablement:

Access these incredible benefits and more:

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Web-1

Web-2

Mobile Web

MobileWeb-1

MobileWeb-2

Desktop

Desktop-1

Desktop-2

iOS

IOS-1

iOS-2

Android

Android-1

Android-2

Screenshots (ES)

Web

Web-1

Web-2

Mobile Web

MobileWeb-1

MobileWeb-2

Desktop

Desktop-1

Desktop-2

iOS

iOS-1

iOS-2

Android

Android-1

Android-2

@PrashantMangukiya PrashantMangukiya requested a review from a team as a code owner November 17, 2021 13:27
@MelvinBot MelvinBot requested review from roryabraham and removed request for a team November 17, 2021 13:27
roryabraham
roryabraham previously approved these changes Nov 17, 2021
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll let @kevinksullivan double-check

@roryabraham roryabraham merged commit f5a1b58 into Expensify:main Nov 20, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants