Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expensify system emails #6347

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Update expensify system emails #6347

merged 1 commit into from
Nov 17, 2021

Conversation

puneetlath
Copy link
Contributor

@puneetlath puneetlath commented Nov 17, 2021 •
edited
Loading

Details

Adds more of the system emails that we should be blocking from being added to policies via front-end validation. I updated the list to match what is in expensify-common here and to be in the same order.

I found this while working on https://github.com/Expensify/Expensify/issues/174181.

Tests

  1. Sign into a new dot account
  2. Create a workspace if one doesn't exist already
  3. Go to the workspace settings and click "manage members"
  4. Click the "invite" button
  5. Try adding any of these system emails to a policy
  6. Ensure that you don't see the option to select the email and add it
  7. Try adding any other email address to the policy
  8. Ensure that you are able to add it

What you see when trying to add a non-system email:
image

What you see when you try to add a system email:
image

QA Steps

  1. Sign into a new dot account
  2. Create a workspace if one doesn't exist already
  3. Go to the workspace settings and click "manage members"
  4. Click the "invite" button
  5. Try adding any of these system emails to a policy
  6. Ensure that you don't see the option to select the email and add it
  7. Try adding any other email address to the policy
  8. Ensure that you are able to add it

System emails:

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@puneetlath puneetlath requested a review from a team November 17, 2021 15:41
@puneetlath puneetlath self-assigned this Nov 17, 2021
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team November 17, 2021 15:41
@MonilBhavsar MonilBhavsar merged commit 7986e4e into main Nov 17, 2021
@MonilBhavsar MonilBhavsar deleted the puneet-update-expensify-emails branch November 17, 2021 17:58
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Nov 22, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @MonilBhavsar in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonilBhavsar MonilBhavsar MonilBhavsar approved these changes

Assignees

@puneetlath puneetlath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puneetlath @OSBotify @MonilBhavsar