Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wen-fix-square-room-avatar #6348

Merged
merged 1 commit into from
Nov 17, 2021
Merged

wen-fix-square-room-avatar #6348

merged 1 commit into from
Nov 17, 2021

Conversation

wenge8n
Copy link
Contributor

@wenge8n wenge8n commented Nov 17, 2021

Details

Room avatar is square instead of circle

Fixed Issues

$ #6288

Tests

  1. Navigate to a room
  2. Tap on the header to access room details

QA Steps

Same as above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Simulator Screen Shot - iPhone 12 - 2021-11-18 at 00 15 24

Android

Screenshot_20211117-235006

@wenge8n wenge8n requested a review from a team as a code owner November 17, 2021 16:17
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team November 17, 2021 16:17
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@wenge8n
Copy link
Contributor Author

wenge8n commented Nov 17, 2021

I have read the CLA Document and I hereby sign the CLA

@Jag96 Jag96 merged commit d2d1718 into Expensify:main Nov 17, 2021
@OSBotify
Copy link
Contributor

@wenge8n, Great job getting your first Expensify/App pull request over the finish line! 🎉

I know there's a lot of information in our contributing guidelines, so here are some points to take note of 📝:

  1. Now that your first PR has been merged, you can be hired for another issue. Once you've completed a few issues, you may be eligible to work on more than one job at a time.
  2. Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that it doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically, we would revert this PR and give you another chance to create a similar PR without causing a regression.
  3. Once your PR is deployed to production, we start a 7-day timer ⏰. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job. 💰

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! 😊

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Nov 22, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Nov 29, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenge8n @OSBotify @Jag96