Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[No QA] Ensure bundle version strings are compatible before auto-merging CP PR" #6350

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Nov 17, 2021

Reverts #6199

This PR ended up breaking CPs, so reverting to unblock CPs while I sort out a better fix for the original issue. More details here: #6199 (comment)

@Jag96 Jag96 requested a review from a team as a code owner November 17, 2021 16:57
@Jag96 Jag96 self-assigned this Nov 17, 2021
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team November 17, 2021 16:58
@Gonals Gonals self-requested a review November 17, 2021 17:07
@Jag96
Copy link
Contributor Author

Jag96 commented Nov 17, 2021

Clean revert, so skipping e2e tests to unblock CPs

@Jag96 Jag96 merged commit bef6d20 into main Nov 17, 2021
@Jag96 Jag96 deleted the revert-6199-joe-check-bundle-version branch November 17, 2021 17:09
@botify
Copy link

botify commented Nov 17, 2021

@Jag96 looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants