Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IOU Modal styles. #6417

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Fix IOU Modal styles. #6417

merged 2 commits into from
Nov 23, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #6415

Tests | QA Steps

  1. Launch the app and login
  2. Click on green Fab button
  3. Tap Request Money
  4. Select amount and click Next

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

Screenshot 2021-11-23 15:40:15

iOS

Android

Screenshot 2021-11-23 15:42:23

@parasharrajat parasharrajat requested a review from a team as a code owner November 23, 2021 10:12
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team November 23, 2021 10:12
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested and works well

@NikkiWines NikkiWines merged commit 1a6590b into Expensify:main Nov 23, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@parasharrajat
Copy link
Member Author

parasharrajat commented Nov 23, 2021

This was supposed to be CP staging. Now someone has to manually do that. I am not sure who is the right person for that.

@chiragsalian
Copy link
Contributor

I gotchu guys. Imma CP it to staging now.

github-actions bot pushed a commit that referenced this pull request Nov 23, 2021
Fix IOU Modal styles.

(cherry picked from commit 1a6590b)
@chiragsalian
Copy link
Contributor

Manually CP'd to staging.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @chiragsalian in version: 1.1.16-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @NikkiWines in version: 1.1.16-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mallenexpensify
Copy link
Contributor

@roryabraham any idea why this was deployed to staging and production twice? cc @michaelhaxhiu @dylanexpensify , we're discussing here

@roryabraham
Copy link
Contributor

roryabraham commented Dec 8, 2021

It's a known issue: #4977 The first set of deploy comments are the correct ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants