Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍒 Cherry pick PR #6319 to staging 🍒 #6452

Merged
merged 3 commits into from
Nov 23, 2021
Merged

🍒 Cherry pick PR #6319 to staging 🍒 #6452

merged 3 commits into from
Nov 23, 2021

Conversation

OSBotify
Copy link
Contributor

🍒 Cherry pick #6319 to staging 🍒

OSBotify and others added 2 commits November 23, 2021 22:35
@OSBotify
Merge pull request #6451 from Expensify/version-BUILD-5bf393b0acceea8…
ff05140 
…3c98772ff73eca60f6937f0d8

(cherry picked from commit e24b86b)
@luacmartins
Merge pull request #6319 from Expensify/cmartins-autoApproveTriggerCl…
deef03c 
…eanUp

Deep link to add secondary login in OldDot

(cherry picked from commit ceba16f)
@OSBotify OSBotify requested a review from a team as a code owner November 23, 2021 22:35
@MelvinBot MelvinBot removed the request for review from a team November 23, 2021 22:35
@OSBotify
Copy link
Contributor Author

This pull request has merge conflicts and can not be automatically merged. 😞
Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge.
Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.

@roryabraham
Copy link
Contributor

@luacmartins @chiragsalian Will you please review this?

@roryabraham
Copy link
Contributor

I had to resolve conflicts, so take a look at the commit I added and make sure it looks good!

@luacmartins luacmartins merged commit de8f909 into staging Nov 23, 2021
@luacmartins luacmartins deleted the roryabraham-cherry-pick-staging-6319 branch November 23, 2021 22:53
@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.16-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragsalian chiragsalian chiragsalian approved these changes

@luacmartins luacmartins luacmartins approved these changes

Assignees

@roryabraham roryabraham

Labels
automerge Engineering Hourly KSv2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OSBotify @roryabraham @chiragsalian @luacmartins