fix: newline via updating the count first before marking the messages as read

[parasharrajat]

Details

Fixed Issues

$ #6424

Tests | QA Steps

1. Go to staging.new.expensify.com on two devices (P & Q).
2. Login with accounts A and B respectively.
3. Go to any chat other than between A and B (1:1)
4. Send messages from A to B on device P.
5. Enter the! 1:1 conversation on device Q that has unread messages and verify there is a green line indicating the New Messages.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

output_file.mp4

Mobile Web

Desktop

iOS

Android

....on the way

[johnmlee101]

LGTM!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[parasharrajat]

Oops @johnmlee101 this needs to be CP'ed.

[johnmlee101]

Running!

[OSBotify]

🚀 Cherry-picked to staging by @johnmlee101 in version: 1.1.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by @johnmlee101 in version: 1.1.16-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[ogumen]

The accessibility issues related to this PR:

1. The green line against white background fails minimum contrast requirements of 3.00:1. The green () against white (#FFFFFF) has a color contrast ratio of 1.95:1 - failure of WCAG SC 1.4.11
2. Same for "New" text with the same color pair used - failure of WCAG SC 1.4.3
   

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅