Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix draft value not displaying in datepicker #6524

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Fix draft value not displaying in datepicker #6524

merged 2 commits into from
Nov 30, 2021

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Nov 30, 2021 •
edited
Loading

Details

Introduced here #6234. Updated BaseExpensiTextInput to use this.value instead of this.props.value.

Fixed Issues

$ #6521

Tests

  1. Log into NewDot.
  2. Create a Workspace and click on Connect bank account
  3. Click on Connect manually and enter 011401533 for routing number and 1111222233331111 for account number. Click Save and continue
  4. In the Company step enter random values and click Save & continue.
  5. Go back and verify that the previously entered date is saved.

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

Android

@luacmartins luacmartins self-assigned this Nov 30, 2021
@luacmartins luacmartins marked this pull request as ready for review November 30, 2021 00:52
@luacmartins luacmartins requested a review from a team as a code owner November 30, 2021 00:52
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team November 30, 2021 00:53
@luacmartins luacmartins mentioned this pull request Nov 30, 2021
Merged
5 tasks
@sketchydroide sketchydroide merged commit ddfa1e4 into main Nov 30, 2021
@sketchydroide sketchydroide deleted the cmartins-datepickerValue branch November 30, 2021 11:35
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Dec 6, 2021
Closed
95 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @sketchydroide in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sketchydroide sketchydroide sketchydroide approved these changes

Assignees

@luacmartins luacmartins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luacmartins @OSBotify @sketchydroide