Handle popover showing from side only in sidebar screen #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jag96
suggested changes
Dec 4, 2021
There was a problem hiding this comment.
It looks like this PR has some regressions, mainly the animations on iOS/Android are now missing (create menu and change profile picture as examples). Can you update this and also add screenshots for the other platforms (iOS non-iPad, Android, Web) to confirm there are no additional regressions?
Jag96
approved these changes
Dec 15, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
37 tasks
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The changes made are to support showing from the side the
popover(FAB options) on iPad.Fixed Issues
$ #6278
$ #6520
$ #6519
$ #6522
Tests
+icon and pressAdd attachment, the nextpopovershould appear from bottom.popovershould appear from the bottom and centered from the sides on the screen.Upload photo, nextpopovershould appear from bottom.QA Steps
+icon and pressAdd attachment, the nextpopovershould appear from bottom.popovershould appear from the bottom and centered from the sides on the screen.Upload photo, nextpopovershould appear from bottom.Tested On
Screenshots
iPhone
iPhone.mp4
iPad
iPad.mp4
Android
android.original.mov
Web
web.original.mov