-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get assistance page #6903
Add get assistance page #6903
Conversation
Ok @Luke9389 @marcaaron I'm ready for another review. Main things that have been updated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just have nabs and there is one missing doc for propTypes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! All NABs from me too. Great job!
Thanks for the feedback y'all! @marcaaron I added the doc you requested if you can give another review. |
@@ -69,12 +64,16 @@ const propTypes = { | |||
requestCallForm: PropTypes.shape({ | |||
loading: PropTypes.bool, | |||
}), | |||
|
|||
/** The policyID of the last workspace whose settings the user accessed */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcaaron the doc is here.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @marcaaron in version: 1.1.27-2 🚀
|
🚀 Deployed to staging by @marcaaron in version: 1.1.27-3 🚀
|
🚀 Deployed to staging by @marcaaron in version: 1.1.27-3 🚀
|
Details
This PR adds a new
Get Assistance
page (shown below) which can be accessed by clicking the new question mark icon in the header of any page in the workspace settings. This page gives the option to chat with concierge or request a call with a guide. A summary of what was added/changed:lastAccessedWorkspace
in Onyx that is updated whenever a workspace is loaded (this is because there are scenarios where we can't get the workspace directly, context here)InboxCallButton
component, which is no longer used anywhere in the workspacelastAccessedWorkspace
for the policy ID to associate with the guides job if it is available, otherwise fall back on the personal policy IDWorkspaceSection
component to be a more genericSection
component that can be used outside the workspaceSection
component on the newGetAssistance
page and updated theRequestCall
page to use it as wellFixed Issues
$ #6719
$ https://github.com/Expensify/Expensify/issues/184190
Tests
/get-assistance/WorkspaceBookTravel
chat with concierge
option navigates you to your Concierge chatrequest a setup call
option takes you to the request a call page with the same task ID in the URL (i.e./request-call/WorkspaceBookTravel
)QA Steps
/get-assistance/WorkspaceBookTravel
chat with concierge
option navigates you to your Concierge chatrequest a setup call
option takes you to the request a call page with the same task ID in the URL (i.e./request-call/WorkspaceBookTravel
)Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android