Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Convert ReportActionItemFragment into function component #7072

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jan 7, 2022

Details

Converts this class component into a functional component per our code style guidelines.

Fixed Issues

$ n/a

Tests

Run the app, verify report action fragments render correctly.

  • Verify that no (new) errors appear in the JS console

QA Steps

None.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

Desktop

image

iOS

Android

@roryabraham roryabraham self-assigned this Jan 7, 2022
@roryabraham roryabraham marked this pull request as ready for review January 12, 2022 05:05
@roryabraham roryabraham requested a review from a team as a code owner January 12, 2022 05:05
@roryabraham roryabraham changed the title [No QA] Convert ReportActionItemFragment into function component [Hold][No QA] Convert ReportActionItemFragment into function component Jan 12, 2022
@MelvinBot MelvinBot requested review from danieldoglas and removed request for a team January 12, 2022 05:06
@roryabraham
Copy link
Contributor Author

Throwing this on hold so I can use it as a dummy PR as part of the QA steps of #6906. Feel free to review but please do not merge yet

@roryabraham roryabraham changed the title [Hold][No QA] Convert ReportActionItemFragment into function component [No QA] Convert ReportActionItemFragment into function component Jan 12, 2022
@roryabraham roryabraham merged commit 23c7dbc into main Jan 12, 2022
@roryabraham roryabraham deleted the Rory-ReportActionItemFragment branch January 12, 2022 19:22
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.28-2 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants