-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Fix Android deploy failures #7112
Conversation
|
Going to put this on HOLD since we have another issue where the iOS deploy is failing |
Taking off hold, this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming here to help with reviewing and QA since this blocks deploy. Changes LGTM and I confirmed that the apps run and the android build works. However, I had to follow these instructions to get the build.
Okay, I'm having some issues creating an android build locally, but I don't want to be a roadblock. Two approvals is enough for me to think we'll be okay to live-test this with a staging deploy. |
(cherry picked from commit c8e312b)
Android deploy was successful 🎉 https://github.com/Expensify/App/runs/4768966594?check_suite_focus=true |
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.27-1 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.27-1 🚀
|
No double-deploy-comment here 🎉 |
Details
This PR removes a deprecated package that is causing Android deploy failures. More context in #7111 (comment).
Fixed Issues
$ #7111
Tests
npm run build-android
and confirm there is no error forCould not find com.facebook.flipper:flipper-noop:0.66.0.
QA Steps
None, I'll confirm CPing this change results in a successful Android build
Tested On
Screenshots