[No QA] Don't rely on non-portable realpath #7137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
changed the title
|
Throwing this on hold so that I can use it as a dummy PR to QA #6906 |
27 tasks
Jag96
approved these changes
Jan 12, 2022
roryabraham
changed the title
roryabraham
changed the title
roryabraham
changed the title
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
54 tasks
|
🚀 Deployed to staging by @roryabraham in version: 1.1.29-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
As explained in this comment,
realpathis not completely portable. This PR implements a workaround to find the absolute path of the script without usingrealpath.Fixed Issues
n/a
Tests
Run the test, verify it passes.
QA Steps
None.