Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Options default style fix" #7186

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

puneetlath
Copy link
Contributor

Reverts #7136

It is causing this deploy blocking issue: #7180 (comment)

@puneetlath puneetlath requested a review from a team as a code owner January 12, 2022 23:33
@puneetlath puneetlath self-assigned this Jan 12, 2022
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from thienlnam and removed request for a team January 12, 2022 23:33
Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chiragsalian chiragsalian merged commit 78b4b60 into main Jan 13, 2022
@chiragsalian chiragsalian deleted the revert-7136-chirag-option-style-fix branch January 13, 2022 00:50
OSBotify pushed a commit that referenced this pull request Jan 13, 2022
…le-fix

Revert "Options default style fix"

(cherry picked from commit 78b4b60)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @chiragsalian in version: 1.1.29-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants